From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH 07/44] qnap-poweroff: Drop reference to pm_power_off from devicetree bindings Date: Tue, 7 Oct 2014 12:02:19 +0100 Message-ID: <20141007110219.GE24725@leverpostej> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-8-git-send-email-linux@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1412659726-29957-8-git-send-email-linux@roeck-us.net> Sender: linux-acpi-owner@vger.kernel.org To: Guenter Roeck Cc: "linux-kernel@vger.kernel.org" , "adi-buildroot-devel@lists.sourceforge.net" , "devel@driverdev.osuosl.org" , "devicetree@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-acpi@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-am33-list@redhat.com" , "linux-cris-kernel@axis.com" , "linux-efi@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-m32r-ja@ml.linux-m32r.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" lin List-Id: devicetree@vger.kernel.org On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote: > Replace reference to pm_power_off (which is an implementation detail) > and replace it with a more generic description of the driver's functionality. > > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Signed-off-by: Guenter Roeck > --- > Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > index af25e77..1e2260a 100644 > --- a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > +++ b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > @@ -3,8 +3,8 @@ > QNAP NAS devices have a microcontroller controlling the main power > supply. This microcontroller is connected to UART1 of the Kirkwood and > Orion5x SoCs. Sending the character 'A', at 19200 baud, tells the > -microcontroller to turn the power off. This driver adds a handler to > -pm_power_off which is called to turn the power off. > +microcontroller to turn the power off. This driver installs a handler > +to power off the system. I'd remove the last sentence -- the driver is also independent of the HW, and the description of how the power off works at the HW level is sufficient. With that: Acked-by: Mark Rutland Thanks, Mark.