From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v3 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property Date: Tue, 7 Oct 2014 13:08:12 +0100 Message-ID: <20141007120812.GJ24725@leverpostej> References: <1412682308-8784-1-git-send-email-darshanapadmadas@gmail.com> <1412682308-8784-5-git-send-email-darshanapadmadas@gmail.com> <11076749.g7xZQflTCQ@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <11076749.g7xZQflTCQ@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: Darshana Padmadas , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Pawel Moll , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, Oct 07, 2014 at 12:49:02PM +0100, Arnd Bergmann wrote: > On Tuesday 07 October 2014 17:15:08 Darshana Padmadas wrote: > > /* ALS and Proximity sensor */ > > isl29028@44 { > > - compatible = "isil,isl29028"; > > + compatible = "isl,isl29028"; > > reg = <0x44>; > > interrupt-parent = <&gpio>; > > interrupts = ; > > > > Does this intentionally list only the new string? > > If we want compatibility between new dts files and old kernels, this would > need to be > > compatible = "isl,isl29028", compatible = "isil,isl29028"; Are we aiming for new dts wto work with old kernels? It's nice if they do, but I don't think it should be necessary. Old DTBs should definitely work with a new kernel, though. Personally I'd rather see one string (preferably the canonical one, but the deprecated one is ok) than two strings when those strings are for the exact same device. Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html