From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 20/44] power/reset: restart-poweroff: Register with kernel poweroff handler Date: Tue, 7 Oct 2014 18:06:38 +0200 Message-ID: <20141007160638.GE19005@lunn.ch> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-21-git-send-email-linux@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1412659726-29957-21-git-send-email-linux@roeck-us.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Guenter Roeck Cc: linux-m32r-ja@ml.linux-m32r.org, linux-mips@linux-mips.org, linux-efi@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Sebastian Reichel , devicetree@vger.kernel.org, devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, lguest@lists.ozlabs.org, linux-c6x-dev@linux-c6x.org, Dmitry Eremin-Solenikov , linux-hexagon@vger.kernel.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, user-mode-linux-devel@lists.sourceforge.net, linux-pm@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, linux-m68k@lists.linux-m68k.org, linux-am33-list@redhat.com, linux-tegra@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-metag@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-cris-kernel@axis.com, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.o List-Id: devicetree@vger.kernel.org On Mon, Oct 06, 2014 at 10:28:22PM -0700, Guenter Roeck wrote: > Register with kernel poweroff handler instead of seting pm_power_off > directly. Register as poweroff handler of last resort since the driver > does not really power off the system but executes a restart. I would not say last resort, this is how it is designed to work. There is no way to turn the power off from with linux, it is designed that u-boot will put the hardware into minimal power consumption until the "power" button is pressed. Other than that, Acked-by: Andrew Lunn Thanks Andrew > > Cc: Sebastian Reichel > Cc: Dmitry Eremin-Solenikov > Cc: David Woodhouse > Signed-off-by: Guenter Roeck > --- > drivers/power/reset/restart-poweroff.c | 25 ++++++++++++------------- > 1 file changed, 12 insertions(+), 13 deletions(-) > > diff --git a/drivers/power/reset/restart-poweroff.c b/drivers/power/reset/restart-poweroff.c > index edd707e..5437697 100644 > --- a/drivers/power/reset/restart-poweroff.c > +++ b/drivers/power/reset/restart-poweroff.c > @@ -12,35 +12,34 @@ > */ > #include > #include > +#include > #include > #include > #include > +#include > #include > -#include > > -static void restart_poweroff_do_poweroff(void) > +static int restart_poweroff_do_poweroff(struct notifier_block *this, > + unsigned long unused1, void *unused2) > { > reboot_mode = REBOOT_HARD; > machine_restart(NULL); > + > + return NOTIFY_DONE; > } > > +static struct notifier_block restart_poweroff_handler = { > + .notifier_call = restart_poweroff_do_poweroff, > +}; > + > static int restart_poweroff_probe(struct platform_device *pdev) > { > - /* If a pm_power_off function has already been added, leave it alone */ > - if (pm_power_off != NULL) { > - dev_err(&pdev->dev, > - "pm_power_off function already registered"); > - return -EBUSY; > - } > - > - pm_power_off = &restart_poweroff_do_poweroff; > - return 0; > + return register_poweroff_handler(&restart_poweroff_handler); > } > > static int restart_poweroff_remove(struct platform_device *pdev) > { > - if (pm_power_off == &restart_poweroff_do_poweroff) > - pm_power_off = NULL; > + unregister_poweroff_handler(&restart_poweroff_handler); > > return 0; > } > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel