From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 12/44] mfd: ab8500-sysctrl: Register with kernel poweroff handler Date: Thu, 9 Oct 2014 11:49:27 +0100 Message-ID: <20141009104927.GN20647@lee--X1> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-13-git-send-email-linux@roeck-us.net> <20141007080048.GB25331@lee--X1> <20141009103656.GF17836@e104818-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20141009103656.GF17836@e104818-lin.cambridge.arm.com> Sender: linux-acpi-owner@vger.kernel.org To: Catalin Marinas Cc: Guenter Roeck , "linux-m32r-ja@ml.linux-m32r.org" , "linux-mips@linux-mips.org" , "linux-efi@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , Linus Walleij , "devel@driverdev.osuosl.org" , "linux-s390@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-c6x-dev@linux-c6x.org" , "linux-hexagon@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "xen-devel@lists.xenproject.org" , devicetree@vger.k List-Id: devicetree@vger.kernel.org On Thu, 09 Oct 2014, Catalin Marinas wrote: > On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote: > > On Mon, 06 Oct 2014, Guenter Roeck wrote: > > > --- a/drivers/mfd/ab8500-sysctrl.c > > > +++ b/drivers/mfd/ab8500-sysctrl.c > > > @@ -6,6 +6,7 @@ > >=20 > > [...] > >=20 > > > +static int ab8500_power_off(struct notifier_block *this, unsigne= d long unused1, > > > + void *unused2) > > > { > > > sigset_t old; > > > sigset_t all; > > > @@ -34,11 +36,6 @@ static void ab8500_power_off(void) > > > struct power_supply *psy; > > > int ret; > > > =20 > > > - if (sysctrl_dev =3D=3D NULL) { > > > - pr_err("%s: sysctrl not initialized\n", __func__); > > > - return; > > > - } > >=20 > > Can you explain the purpose of this change please? >=20 > I guess it's because the sysctrl_dev is already initialised when > registering the power_off handler, so there isn't a way to call the > above function with a NULL sysctrl_dev. Probably even with the origin= al > code you didn't need this check (after some race fix in > ab8500_sysctrl_remove but races is one of the things Guenter's patche= s > try to address). Sounds reasonable, although I think this change should be part of another patch. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html