Re: [PATCH 02/12] rtc: omap: fix missing wakealarm attribute

From: Felipe Balbi <balbi@ti.com>
To: Johan Hovold <johan@kernel.org>
Cc: "Alessandro Zummo" <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com,
	"Colin Foe-Parker" <colin.foeparker@logicpd.com>,
	devicetree@vger.kernel.org, "Tony Lindgren" <tony@atomide.com>,
	j-keerthy@ti.com, nsekhar@ti.com, linux-kernel@vger.kernel.org,
	"Felipe Balbi" <balbi@ti.com>,
	t-kristo@ti.com, "Lokesh Vutla" <lokeshvutla@ti.com>,
	linux-arm-kernel@lists.infradead.org,
	"Benoît Cousson" <bcousson@baylibre.com>,
	stable <stable@vger.kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	linux-omap@vger.kernel.org, "Guenter Roeck" <linux@roeck-us.net>
Subject: Re: [PATCH 02/12] rtc: omap: fix missing wakealarm attribute
Date: Fri, 10 Oct 2014 12:55:49 -0500	[thread overview]
Message-ID: <20141010175549.GN31348@saruman> (raw)
In-Reply-To: <1412881594-25678-3-git-send-email-johan@kernel.org>


[-- Attachment #1.1: Type: text/plain, Size: 1725 bytes --]

On Thu, Oct 09, 2014 at 09:06:24PM +0200, Johan Hovold wrote:
> The platform device must be registered as wakeup capable before
> registering the class device, or the wakealarm attribute will not be
> created.
> 
> Also make sure to unregister the wakeup source on probe errors.
> 
> Fixes: 1d2e2b65d098 ("rtc: omap: restore back (hard-code) wakeup support")
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---

Reviewed-by: Felipe Balbi <balbi@ti.com>

>  drivers/rtc/rtc-omap.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
> index f842c216f2dd..828cb9983cc2 100644
> --- a/drivers/rtc/rtc-omap.c
> +++ b/drivers/rtc/rtc-omap.c
> @@ -416,6 +416,8 @@ static int __init omap_rtc_probe(struct platform_device *pdev)
>  		rtc_writel(KICK1_VALUE, OMAP_RTC_KICK1_REG);
>  	}
>  
> +	device_init_wakeup(&pdev->dev, true);
> +
>  	rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
>  			&omap_rtc_ops, THIS_MODULE);
>  	if (IS_ERR(rtc)) {
> @@ -484,8 +486,6 @@ static int __init omap_rtc_probe(struct platform_device *pdev)
>  	 *    is write-only, and always reads as zero...)
>  	 */
>  
> -	device_init_wakeup(&pdev->dev, true);
> -
>  	if (new_ctrl & (u8) OMAP_RTC_CTRL_SPLIT)
>  		pr_info("%s: split power mode\n", pdev->name);
>  
> @@ -495,6 +495,7 @@ static int __init omap_rtc_probe(struct platform_device *pdev)
>  	return 0;
>  
>  fail0:
> +	device_init_wakeup(&pdev->dev, false);
>  	if (id_entry->driver_data & OMAP_RTC_HAS_KICKER)
>  		rtc_writel(0, OMAP_RTC_KICK0_REG);
>  	pm_runtime_put_sync(&pdev->dev);
> -- 
> 2.0.4
> 

-- 
balbi

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel