From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v4] dma: Add Xilinx AXI Direct Memory Access Engine driver support Date: Wed, 15 Oct 2014 19:02:48 +0530 Message-ID: <20141015133248.GQ1638@intel.com> References: <1413374436-14410-1-git-send-email-sthokal@xilinx.com> <20141015124527.GA20034@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20141015124527.GA20034@leverpostej> Sender: linux-kernel-owner@vger.kernel.org To: Mark Rutland Cc: Srikanth Thokala , "dan.j.williams@intel.com" , "michals@xilinx.com" , "grant.likely@linaro.org" , "robh+dt@kernel.org" , "linux-kernel@vger.kernel.org" , "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "anirudh@xilinx.com" , "svemula@xilinx.com" , "appanad@xilinx.com" List-Id: devicetree@vger.kernel.org On Wed, Oct 15, 2014 at 01:45:28PM +0100, Mark Rutland wrote: > Hi, > > On Wed, Oct 15, 2014 at 01:00:36PM +0100, Srikanth Thokala wrote: > > This is the driver for the AXI Direct Memory Access (AXI DMA) > > core, which is a soft Xilinx IP core that provides high- > > bandwidth direct memory access between memory and AXI4-Stream > > type target peripherals. > > > > This module works on Zynq (ARM Based SoC) and Microblaze platforms. > > > > Signed-off-by: Srikanth Thokala > > --- > > Changes in v4: > > - Add direction field to VDMA descriptor structure and removed from > > channel structure to avoid duplication. > > - Check for DMA idle condition before changing the configuration. > > - Residue is being calculated in complete_descriptor() and is reported > > to slave driver. > > > > Changes in v3: > > - Rebased on 3.16-rc7 > > > > Changes in v2: > > - Simplified the logic to set SOP and APP words in prep_slave_sg(). > > - Corrected function description comments to match the return type. > > - Fixed some minor comments as suggested by Andy, Thanks. > > This patch has come without the necessary device tree binding document, > and I was not able to find an existing binding document upstream (I > searched for "xlnx,axi-dma-1.00.a" and "axi-dma"). which tree did you grep. This is present in slave-dmaengine.git commit ddc643630f5deb1995d191719086b64873c67a44 Author: Srikanth Thokala Date: Mon Jul 28 17:47:48 2014 +0530 dma: Add Xilinx AXI DMA DT Binding Documentation Device-tree binding documentation of Xilinx DMA Engine Signed-off-by: Srikanth Thokala Acked-by: Arnd Bergmann Signed-off-by: Vinod Koul -- ~Vinod > > The driver expects a non-trivial set of properties, so a binding > document is essential for users. Additionally, checkpatch.pl should > scream regarding the undocumented comaptible string. > > Please put together a binding document. > > Thanks, > Mark. --