devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Srikanth Thokala
	<sthokal-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
	"dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
	<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"michals-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org"
	<michals-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
	"grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"anirudh-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org"
	<anirudh-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
	"svemula-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org"
	<svemula-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
	"appanad-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org"
	<appanad-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v4] dma: Add Xilinx AXI Direct Memory Access Engine driver support
Date: Wed, 15 Oct 2014 16:00:36 +0100	[thread overview]
Message-ID: <20141015150036.GF20034@leverpostej> (raw)
In-Reply-To: <20141015133248.GQ1638-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On Wed, Oct 15, 2014 at 02:32:48PM +0100, Vinod Koul wrote:
> On Wed, Oct 15, 2014 at 01:45:28PM +0100, Mark Rutland wrote:
> > Hi,
> > 
> > On Wed, Oct 15, 2014 at 01:00:36PM +0100, Srikanth Thokala wrote:
> > > This is the driver for the AXI Direct Memory Access (AXI DMA)
> > > core, which is a soft Xilinx IP core that provides high-
> > > bandwidth direct memory access between memory and AXI4-Stream
> > > type target peripherals.
> > > 
> > > This module works on Zynq (ARM Based SoC) and Microblaze platforms.
> > > 
> > > Signed-off-by: Srikanth Thokala <sthokal-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
> > > ---
> > > Changes in v4:
> > > - Add direction field to VDMA descriptor structure and removed from
> > >   channel structure to avoid duplication.
> > > - Check for DMA idle condition before changing the configuration.
> > > - Residue is being calculated in complete_descriptor() and is reported
> > >   to slave driver.
> > > 
> > > Changes in v3:
> > > - Rebased on 3.16-rc7
> > > 
> > > Changes in v2:
> > > - Simplified the logic to set SOP and APP words in prep_slave_sg().
> > > - Corrected function description comments to match the return type.
> > > - Fixed some minor comments as suggested by Andy, Thanks.
> > 
> > This patch has come without the necessary device tree binding document,
> > and I was not able to find an existing binding document upstream (I
> > searched for "xlnx,axi-dma-1.00.a" and "axi-dma").
> which tree did you grep. 

Torvalds'

> This is present in slave-dmaengine.git 
> 
> commit ddc643630f5deb1995d191719086b64873c67a44
> Author: Srikanth Thokala <sthokal-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
> Date:   Mon Jul 28 17:47:48 2014 +0530
> 
>     dma: Add Xilinx AXI DMA DT Binding Documentation
> 
>     Device-tree binding documentation of Xilinx DMA Engine
> 
>     Signed-off-by: Srikanth Thokala <sthokal-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
>     Acked-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
>     Signed-off-by: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

I see. Thanks for the pointer.

Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-10-15 15:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-15 12:00 [PATCH v4] dma: Add Xilinx AXI Direct Memory Access Engine driver support Srikanth Thokala
2014-10-15 12:45 ` Mark Rutland
2014-10-15 13:32   ` Vinod Koul
     [not found]     ` <20141015133248.GQ1638-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-15 15:00       ` Mark Rutland [this message]
2014-10-15 14:34   ` Srikanth Thokala
2014-10-20 19:37 ` Arnd Bergmann
2014-10-21  9:06   ` Appana Durga Kedareswara Rao
2014-10-21  9:14     ` Arnd Bergmann
2014-10-24 12:08       ` Appana Durga Kedareswara Rao
2014-10-24 13:58         ` Arnd Bergmann
2015-01-19 14:08           ` Appana Durga Kedareswara Rao
2015-01-29 11:24           ` Appana Durga Kedareswara Rao
2015-02-12  9:34             ` Vinod Koul
2015-02-14 14:21               ` Appana Durga Kedareswara Rao
     [not found]                 ` <ed439c7a25d0465d9dbf4c06987d42a1-neA4ZlFjCT2qEU4nYqjAjmYJ4DzVTqeXkX/xN29GLwg@public.gmane.org>
2015-02-20  6:29                   ` Vinod Koul
2015-02-20 10:42                     ` Michal Simek
     [not found]                       ` <ad1002303e814d53866349674d22fc11-neA4ZlFjCT0GPAd83OwqBWYJ4DzVTqeXkX/xN29GLwg@public.gmane.org>
2015-03-02 16:38                         ` Vinod Koul
     [not found]                     ` <54E70F97.30908@xilinx.com>
2015-03-02  9:04                       ` Appana Durga Kedareswara Rao
2015-02-05 13:31           ` Appana Durga Kedareswara Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141015150036.GF20034@leverpostej \
    --to=mark.rutland-5wv7dgnigg8@public.gmane.org \
    --cc=anirudh-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
    --cc=appanad-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
    --cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=michals-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sthokal-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
    --cc=svemula-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
    --cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).