Re: Re: [PATCH v2 4/4] ARM: dts: sun7i: Add lradc node

Hans de Goede
2014-10-22T08:46:27Z

Hi,

On 10/22/2014 10:38 AM, Maxime Ripard wrote:
> Hi Hans,
>
> On Tue, Oct 21, 2014 at 10:24:50AM +0200, Hans de Goede wrote:
>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>> arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 48 +++++++++++++++++++++++++
>> arch/arm/boot/dts/sun7i-a20.dtsi | 7 ++++
>> 2 files changed, 55 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
>> index 9d669cdf..85e7194 100644
>> --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
>> +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
>> @@ -14,6 +14,7 @@
>> /dts-v1/;
>> /include/ "sun7i-a20.dtsi"
>> /include/ "sunxi-common-regulators.dtsi"
>> +#include <dt-bindings/input/input.h>
>
> I'm just wondering... Weren't we supposed to switch all includes to
> the preprocessor syntax in such a case?

I've just checked other in tree users of dt-bindings/input/input.h and you
seem to be right, I will fix this for the next version.

Regards,

Hans