Re: [PATCH v2 3/4] ARM: dts: sun5i: Add lradc node

Dmitry Torokhov
2014-10-21T16:21:59Z

Hi Hans,

On Tue, Oct 21, 2014 at 10:24:49AM +0200, Hans de Goede wrote:
> + button@98 {
> + label = "Home";
> + linux,code = <KEY_HOME>;

I do not think you really want KEY_HOME (go to the beginning of the
line) here, KEY_HOMEPAGE or similar would suit better.

> + channel = <0>;
> + voltage = <987387>;
> + };
> + };

Thanks.

--
Dmitry