From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Mark Brown <broonie@kernel.org>,
atull@opensource.altera.com, jgunthorpe@obsidianresearch.com,
hpa@zytor.com, Michal Simek <monstr@monstr.eu>,
michal.simek@xilinx.com, rdunlap@infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, robh+dt@kernel.org,
Grant Likely <grant.likely@linaro.org>,
iws@ovro.caltech.edu, linux-doc@vger.kernel.org,
Pavel Machek <pavel@denx.de>,
philip@balister.org, rubini@gnudd.com, jason@lakedaemon.net,
kyle.teske@ni.com, nico@linaro.org, Felipe Balbi <balbi@ti.com>,
m.chehab@samsung.com, davidb@codeaurora.org,
Rob Landley <rob@landley.net>,
davem@davemloft.net, cesarb@cesarb.net, sameo@linux.intel.com,
akpm@linux-foundation.org,
Linus Walleij <linus.walleij@linaro.org>,
mgerlach@opensource.altera.com,
Alan Tull <delicious.quinoa@gmail.com>, dinguyen@opensource.
Subject: Re: [PATCH v2 2/3] ARM: dts: socfpga: fpga bridges bindings docs
Date: Mon, 27 Oct 2014 16:32:05 +0100 [thread overview]
Message-ID: <20141027153205.GW10262@pengutronix.de> (raw)
In-Reply-To: <31BBCD26-65E2-431A-9ADF-95D7EDC7E34E@konsulko.com>
On Mon, Oct 27, 2014 at 05:05:29PM +0200, Pantelis Antoniou wrote:
> Hi Mark,
>
> > On Oct 27, 2014, at 17:01 , Mark Brown <broonie@kernel.org> wrote:
> >
> > On Mon, Oct 27, 2014 at 01:48:02PM +0200, Pantelis Antoniou wrote:
> >>> On Oct 24, 2014, at 02:51 , atull@opensource.altera.com wrote:
> >
> >>> + - init-val : 0 if driver should disable bridge at startup
> >>> + 1 if driver should enable bridge at startup
> >>> + driver leaves bridge in current state if property not
> >>> + specified.
> >
> >> Isn’t init-val a boolean property? It’s not named very well.
> >
> > It's not boolean, it's tristate - turn on, turn off or don't touch.
> >
>
> I see. Even then ‘init-val’ is cryptic. I’d prefer two booleans,
> enable-at-startup; disable-at-startup.
>
> >> Along with the label, is kinda hard to defend as configuration in DT.
> >
> > Yeah... presumably this decision would fall out of the users?
>
> Well, it’s the user that should make the decision, but the driver should
> pick it up. This works but it’s not very nice.
>
Hm, convince me why this AXI bus is so special, that I even need an
"init-val" property? Other buses don't have that.
Why don't I add a property "init-val" to my SPI buses, so I can enable
it in the DT and still have it in reset, just because....
The bridges on the SoCFPGA are buses, from the HPS to the FPGA. If I have
written firmware to the FPGA and I have subnodes on that bus, I have to
get it out of reset and probe everything. Normal procedure, no ?!
Regards,
Steffen
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2014-10-27 15:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 23:51 [PATCH v2 0/3] fpga bridge framework atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-10-23 23:51 ` [PATCH v2 1/3] add sysfs document for fpga bridges atull
2014-10-24 10:54 ` Pavel Machek
2014-10-24 15:11 ` atull
2014-10-29 8:25 ` Pavel Machek
2014-10-23 23:51 ` [PATCH v2 2/3] ARM: dts: socfpga: fpga bridges bindings docs atull
2014-10-24 7:00 ` Steffen Trumtrar
2014-10-24 9:20 ` Pantelis Antoniou
2014-10-25 14:42 ` Steffen Trumtrar
2014-10-27 11:54 ` Pantelis Antoniou
2014-10-27 15:23 ` Steffen Trumtrar
2014-10-27 15:52 ` Pantelis Antoniou
2014-10-27 17:47 ` Steffen Trumtrar
[not found] ` <20141024070042.GL10262-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-10-28 21:19 ` atull
2014-10-28 21:53 ` atull
2014-10-29 7:57 ` Steffen Trumtrar
2014-10-29 10:16 ` Mark Brown
2014-10-29 10:31 ` Steffen Trumtrar
2014-10-29 14:30 ` atull
2014-10-29 20:49 ` atull
2014-10-29 8:24 ` Pavel Machek
2014-10-29 20:39 ` atull
2014-10-24 10:57 ` Pavel Machek
2014-10-27 11:48 ` Pantelis Antoniou
2014-10-27 15:01 ` Mark Brown
2014-10-27 15:05 ` Pantelis Antoniou
2014-10-27 15:32 ` Steffen Trumtrar [this message]
2014-10-27 15:45 ` Pantelis Antoniou
2014-10-27 17:17 ` Mark Brown
2014-10-27 17:21 ` Pantelis Antoniou
2014-10-27 18:00 ` Steffen Trumtrar
2014-10-27 18:03 ` Pantelis Antoniou
2014-10-23 23:51 ` [PATCH v2 3/3] fpga bridge driver atull
2014-10-27 11:37 ` Pantelis Antoniou
2014-10-23 23:57 ` [PATCH v2 0/3] fpga bridge framework atull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027153205.GW10262@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=atull@opensource.altera.com \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=cesarb@cesarb.net \
--cc=davem@davemloft.net \
--cc=davidb@codeaurora.org \
--cc=delicious.quinoa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource. \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=iws@ovro.caltech.edu \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kyle.teske@ni.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mgerlach@opensource.altera.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=nico@linaro.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=pavel@denx.de \
--cc=philip@balister.org \
--cc=rdunlap@infradead.org \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=rubini@gnudd.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).