From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steffen Trumtrar Subject: Re: [PATCH v2 2/3] ARM: dts: socfpga: fpga bridges bindings docs Date: Mon, 27 Oct 2014 16:32:05 +0100 Message-ID: <20141027153205.GW10262@pengutronix.de> References: <1414108267-22058-1-git-send-email-atull@opensource.altera.com> <1414108267-22058-3-git-send-email-atull@opensource.altera.com> <20141027150147.GX18557@sirena.org.uk> <31BBCD26-65E2-431A-9ADF-95D7EDC7E34E@konsulko.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <31BBCD26-65E2-431A-9ADF-95D7EDC7E34E@konsulko.com> Sender: linux-kernel-owner@vger.kernel.org To: Pantelis Antoniou Cc: Mark Brown , atull@opensource.altera.com, jgunthorpe@obsidianresearch.com, hpa@zytor.com, Michal Simek , michal.simek@xilinx.com, rdunlap@infradead.org, Greg Kroah-Hartman , linux-kernel , devicetree@vger.kernel.org, robh+dt@kernel.org, Grant Likely , iws@ovro.caltech.edu, linux-doc@vger.kernel.org, Pavel Machek , philip@balister.org, rubini@gnudd.com, jason@lakedaemon.net, kyle.teske@ni.com, nico@linaro.org, Felipe Balbi , m.chehab@samsung.com, davidb@codeaurora.org, Rob Landley , davem@davemloft.net, cesarb@cesarb.net, sameo@linux.intel.com, akpm@linux-foundation.org, Linus Walleij , mgerlach@opensource.altera.com, Alan Tull , dinguyen@opensource. List-Id: devicetree@vger.kernel.org On Mon, Oct 27, 2014 at 05:05:29PM +0200, Pantelis Antoniou wrote: > Hi Mark, >=20 > > On Oct 27, 2014, at 17:01 , Mark Brown wrote: > >=20 > > On Mon, Oct 27, 2014 at 01:48:02PM +0200, Pantelis Antoniou wrote: > >>> On Oct 24, 2014, at 02:51 , atull@opensource.altera.com wrote: > >=20 > >>> + - init-val : 0 if driver should disable bridge at start= up > >>> + 1 if driver should enable bridge at startu= p > >>> + driver leaves bridge in current state if p= roperty not > >>> + specified. > >=20 > >> Isn=E2=80=99t init-val a boolean property? It=E2=80=99s not named = very well. > >=20 > > It's not boolean, it's tristate - turn on, turn off or don't touch. > >=20 >=20 > I see. Even then =E2=80=98init-val=E2=80=99 is cryptic. I=E2=80=99d p= refer two booleans, > enable-at-startup; disable-at-startup. >=20 > >> Along with the label, is kinda hard to defend as configuration in = DT. > >=20 > > Yeah... presumably this decision would fall out of the users? >=20 > Well, it=E2=80=99s the user that should make the decision, but the dr= iver should > pick it up. This works but it=E2=80=99s not very nice. >=20 Hm, convince me why this AXI bus is so special, that I even need an "init-val" property? Other buses don't have that. Why don't I add a property "init-val" to my SPI buses, so I can enable it in the DT and still have it in reset, just because.... The bridges on the SoCFPGA are buses, from the HPS to the FPGA. If I ha= ve written firmware to the FPGA and I have subnodes on that bus, I have to get it out of reset and probe everything. Normal procedure, no ?! Regards, Steffen --=20 Pengutronix e.K. | = | Industrial Linux Solutions | http://www.pengutronix.de/= | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 = | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-555= 5 |