From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: Re: [PATCH v1 01/10] of: Rename "poweroff-source" property to "system-power-controller" Date: Mon, 27 Oct 2014 18:02:37 +0100 Message-ID: <20141027170237.GG2006@localhost> References: <1414427215-14380-1-git-send-email-romain.perier@gmail.com> <20141027163840.GA14253@saruman> <20141027164103.GD2006@localhost> <20141027164741.GJ14253@saruman> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20141027164741.GJ14253@saruman> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Felipe Balbi Cc: Johan Hovold , Romain Perier , heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, Oct 27, 2014 at 11:47:41AM -0500, Felipe Balbi wrote: > On Mon, Oct 27, 2014 at 05:41:03PM +0100, Johan Hovold wrote: > > On Mon, Oct 27, 2014 at 11:38:40AM -0500, Felipe Balbi wrote: > > > On Mon, Oct 27, 2014 at 04:26:46PM +0000, Romain Perier wrote: > > > > As discussed on the mailing list, it makes more sense to rename this property > > > > to "system-power-controller". Problem being that the word "source" usually tends > > > > to be used for inputs and that is out of control of the OS. The poweroff > > > > capability is an output which simply turns the system-power off. Also, this > > > > property might be used by drivers which power-off the system and power back on > > > > subsequent RTC alarms. This seems to suggest to remove "poweroff" from the > > > > property name and to choose "system-power-controller" as the more generic name. > > > > This patchs adds the required renaming changes and defines an helper function > > > > which is compatible with both properties, the old one prefixed by a vendor name > > > > and the new one without any prefix. > > > > > I think you still need to support poweroff-source since it has been > > > released on a stable kernel. Perhaps add a warning message telling users > > > it's deprecated and asking them to switch over to > > > system-power-controller ? Still, simply removing it isn't very nice. > > > > No, Romain sent a patch that replaced ",system-power-controller" > > with "poweroff-source". It's now in Mark's tree (for v3.19), and this > > series "reverts" to the old name minus the vendor-prefix. > > oh, so poweroff-source isn't in Linus' tree yet ? (/me goes grep) > > Then it should be fine. My bad. > > Many of the other comments are still valid because even though > poweroff-source isn't in mainline yet, this series still creates > bisection points which are broken. The best solution would be to drop > all those patches from Mark's tree. Read, not revert, drop. I agree. Johan