devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-sh@vger.kernel.org, devicetree@vger.kernel.org,
	Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH 1/2] clk: shmobile: mstp: Update DT bindings to use clock-indices property
Date: Thu, 30 Oct 2014 10:47:08 +0900	[thread overview]
Message-ID: <20141030014708.GK22052@verge.net.au> (raw)
In-Reply-To: <1414622133-27247-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

On Thu, Oct 30, 2014 at 12:35:32AM +0200, Laurent Pinchart wrote:
> The renesas,clock-indices property got standardized, replace it with
> clock-indices.
> 
> The MSTP clock driver supports both the old and new properties.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

This change is fine by me, but it seems to be very similar to a
change sent by Geert. My comment with regards to that was:

I'd appreciate it if you could pick this up (or at least indicate that
you intend to) so I can pick up the remaining in this series that
make use of the new binding.

Acked-by: Simon Horman <horms+renesas@verge.net.au>

I have no particular preference for which version of this patch is accepted.

> ---
>  .../devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt         | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Mike, can you please take this in your tree for v3.19 ?
> 
> diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt b/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt
> index a5f52238c80d..2e18676bd4b5 100644
> --- a/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt
> +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt
> @@ -26,11 +26,11 @@ Required Properties:
>      must appear in the same order as the output clocks.
>    - #clock-cells: Must be 1
>    - clock-output-names: The name of the clocks as free-form strings
> -  - renesas,clock-indices: Indices of the gate clocks into the group (0 to 31)
> +  - clock-indices: Indices of the gate clocks into the group (0 to 31)
>  
> -The clocks, clock-output-names and renesas,clock-indices properties contain one
> -entry per gate clock. The MSTP groups are sparsely populated. Unimplemented
> -gate clocks must not be declared.
> +The clocks, clock-output-names and clock-indices properties contain one entry
> +per gate clock. The MSTP groups are sparsely populated. Unimplemented gate
> +clocks must not be declared.
>  
>  
>  Example
> -- 
> 2.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  parent reply	other threads:[~2014-10-30  1:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 22:35 [PATCH 1/2] clk: shmobile: mstp: Update DT bindings to use clock-indices property Laurent Pinchart
2014-10-29 22:35 ` [PATCH 2/2] ARM: shmobile: dts: Use MSTP " Laurent Pinchart
2014-10-30  1:44   ` Simon Horman
2014-10-30  1:47 ` Simon Horman [this message]
2014-10-30 10:23   ` [PATCH 1/2] clk: shmobile: mstp: Update DT bindings to use " Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141030014708.GK22052@verge.net.au \
    --to=horms@verge.net.au \
    --cc=devicetree@vger.kernel.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    --cc=mturquette@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).