devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Vignesh R <vigneshr@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	Tony Lindgren <tony@atomide.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/3] arm: boot: dts: am4372: add tscadc DT entries for am437x-evm and am43x-epos-evm
Date: Fri, 31 Oct 2014 08:46:56 -0500	[thread overview]
Message-ID: <20141031134656.GC24708@kahuna> (raw)
In-Reply-To: <1414741603-18233-4-git-send-email-vigneshr@ti.com>

On 13:16-20141031, Vignesh R wrote:
> This patch adds tscadc DT entries for am437x-gp-evm and am43x-epos-evm.
> 
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
>  arch/arm/boot/dts/am4372.dtsi        | 20 ++++++++++++++++++++
>  arch/arm/boot/dts/am437x-gp-evm.dts  |  8 ++++++++
>  arch/arm/boot/dts/am43x-epos-evm.dts |  8 ++++++++

I personally prefer the soc dt split off from board dt, but others
prefer this as done here.. no objections either way.

>  3 files changed, 36 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index 46660ffd2b65..fd2de8f256e6 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -667,6 +667,26 @@
>  			};
>  		};
>  
> +		tscadc: tscadc@44e0d000 {
> +			compatible = "ti,am4372-tscadc","ti,am3359-tscadc";
^^ bindings ?
$ git grep ti,am4372-tscadc Documentation/devicetree/bindings/
	returns nothing as of 3.18-rc2

> +			reg = <0x44e0d000 0x1000>;
> +			ti,hwmods = "adc_tsc";
> +			interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&adc_tsc_fck>;
> +			clock-names = "fck";
> +			status = "disabled";
> +
> +			tsc {
> +				compatible = "ti,am4372-tsc", "ti,am3359-tsc";
> +			};
> +
> +			adc {
> +				#io-channel-cells = <1>;
> +				compatible = "ti,am4372-adc", "ti,am3359-adc";
> +			};
> +
> +		};
> +
>  		sham: sham@53100000 {
>  			compatible = "ti,omap5-sham";
>  			ti,hwmods = "sham";
> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
> index e7ac47fa6615..2ffd6d6dcc87 100644
> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
> @@ -343,6 +343,14 @@
>  	status = "okay";
>  };
>  
> +&tscadc {
> +	status = "okay";
> +
> +	adc {
> +		ti,adc-channels = <0 1 2 3 4 5 6 7>;
> +	};
> +};
> +
>  &ecap0 {
>  	status = "okay";
>  	pinctrl-names = "default";
> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
> index ac3e4859935f..f9bc607f3b3a 100644
> --- a/arch/arm/boot/dts/am43x-epos-evm.dts
> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts
> @@ -519,6 +519,14 @@
>  	status = "okay";
>  };
>  
> +&tscadc {
> +	status = "okay";
> +
> +	adc {
> +		ti,adc-channels = <0 1 2 3 4 5 6 7>;
> +	};
> +};
> +
>  &ecap0 {
>  		status = "okay";
>  		pinctrl-names = "default";
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Regards,
Nishanth Menon

  reply	other threads:[~2014-10-31 13:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31  7:46 [PATCH 0/3] Add support for ADC on am437x-gp and am43x-epos-evm Vignesh R
2014-10-31  7:46 ` [PATCH 1/3] arm: mach-omap2: omap_hwmod_33xx_43xx_ipblock_data: Move am33xx_l4_hs_hwmod to ipblock_data Vignesh R
2014-10-31  7:46 ` [PATCH 2/3] arm: mach-omap2: omap_hwmod_43xx_data: add hwmod support for tscadc on am43x-evm Vignesh R
2014-10-31 13:44   ` Nishanth Menon
2014-11-04 11:15     ` Vignesh R
2014-10-31  7:46 ` [PATCH 3/3] arm: boot: dts: am4372: add tscadc DT entries for am437x-evm and am43x-epos-evm Vignesh R
2014-10-31 13:46   ` Nishanth Menon [this message]
2014-11-04 11:15     ` Vignesh R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141031134656.GC24708@kahuna \
    --to=nm@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).