From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gyungoh Yoo Subject: Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding Date: Tue, 4 Nov 2014 14:45:34 +0900 Message-ID: <20141104054534.GA4108@jack-ThinkPad-T520> References: <1414393369-31583-1-git-send-email-jack.yoo@skyworksinc.com> <1414739322-12487-1-git-send-email-jack.yoo@skyworksinc.com> <1414739322-12487-8-git-send-email-jack.yoo@skyworksinc.com> <20141031164418.GC18557@sirena.org.uk> <20141104004333.GA2965@jack-ThinkPad-T520> <20141104005329.GA3815@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20141104005329.GA3815-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jack.yoo-tjhQNA90jdKqndwCJWfcng@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org, shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org, treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, florian.vaussard-p8DiymsW2f8@public.gmane.org, trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, andrew-g2DYL2Zd6BY@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Nov 04, 2014 at 12:53:29AM +0000, Mark Brown wrote: > On Tue, Nov 04, 2014 at 09:43:34AM +0900, Gyungoh Yoo wrote: > > On Fri, Oct 31, 2014 at 04:44:18PM +0000, Mark Brown wrote: > > > > This doesn't apply against current code and depends on the MFD symbol > > > rename - can you please check what's going on here? > > > Are you talking about 'sky81452-regulator'? > > I am sorry I don't understand. Can you explain in more detail? > > No, I mean the Kconfig change. > > > > It would make sense to split the Kconfig symbol rename into a separate > > > patch to ease merging, it doesn't seem obviously related to the driver > > > change and should probably be in the same patch as the MFD symbol rename > > > for bisetion. > > > becuase the symbol in the modfied MFD does not match with the > > merged regulator driver, it was hard to split the patch. > > I'm having a hard time understanding why it is difficult to split the > two changes - they are in completely separate files. I am sorry for the hard time. That was because the symbol changes had a dependency with 1/8. In this case, Should Kconfig symbol change back from MFD_SKY81452 to SKY81452 in this patch series? And then should I submit to change to MFD_SKY81452 with seperate patch? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html