From: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Jingchang Lu <jingchang.lu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] arm: imx: clean up machine mxc_arch_reset_init_dt reset init
Date: Tue, 4 Nov 2014 14:12:14 +0800 [thread overview]
Message-ID: <20141104061212.GH10821@tiger> (raw)
In-Reply-To: <1414748393-20799-1-git-send-email-jingchang.lu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
On Fri, Oct 31, 2014 at 05:39:53PM +0800, Jingchang Lu wrote:
> diff --git a/arch/arm/mach-imx/imx31-dt.c b/arch/arm/mach-imx/imx31-dt.c
> index 418dbc8..e0a4e2f 100644
> --- a/arch/arm/mach-imx/imx31-dt.c
> +++ b/arch/arm/mach-imx/imx31-dt.c
> @@ -15,16 +15,8 @@
> #include <asm/mach/arch.h>
> #include <asm/mach/time.h>
>
> -#include "common.h"
The change causes the build errors below.
CC arch/arm/mach-imx/imx31-dt.o
../arch/arm/mach-imx/imx31-dt.c: In function ‘imx31_dt_timer_init’:
../arch/arm/mach-imx/imx31-dt.c:27:2: error: implicit declaration of function ‘mx31_clocks_init_dt’ [-Werror=implicit-function-declaration]
../arch/arm/mach-imx/imx31-dt.c: At top level:
../arch/arm/mach-imx/imx31-dt.c:31:13: error: ‘mx31_map_io’ undeclared here (not in a function)
../arch/arm/mach-imx/imx31-dt.c:32:16: error: ‘imx31_init_early’ undeclared here (not in a function)
../arch/arm/mach-imx/imx31-dt.c:33:14: error: ‘mx31_init_irq’ undeclared here (not in a function)
So the common.h inclusion needs to be kept. I fixed it up and applied the patch.
Shawn
> #include "mx31.h"
>
> -static void __init imx31_dt_init(void)
> -{
> - mxc_arch_reset_init_dt();
> -
> - of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> -}
> -
> static const char * const imx31_dt_board_compat[] __initconst = {
> "fsl,imx31",
> NULL
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-04 6:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 9:39 [PATCH] arm: imx: clean up machine mxc_arch_reset_init_dt reset init Jingchang Lu
[not found] ` <1414748393-20799-1-git-send-email-jingchang.lu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-11-04 6:12 ` Shawn Guo [this message]
2014-11-04 6:24 ` Jingchang Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104061212.GH10821@tiger \
--to=shawn.guo-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jingchang.lu-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).