Re: [PATCH 0/2] make imx hdmi publicly used by dw hdmi compatible platform - Russell King

From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: heiko@sntech.de, dri-devel@lists.freedesktop.org,
	ykk@rock-chips.com, devel@driverdev.osuosl.org,
	linux-rockchip@lists.infradead.org,
	Grant Likely <grant.likely@linaro.org>,
	Dave Airlie <airlied@redhat.com>,
	devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com,
	Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
	fabio.estevam@freescale.com, Josh Boyer <jwboyer@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, djkurtz@google.com
Subject: Re: [PATCH 0/2] make imx hdmi publicly used by dw hdmi compatible platform
Date: Tue, 4 Nov 2014 14:29:09 +0000	[thread overview]
Message-ID: <20141104142908.GG4042@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1415107992-34289-1-git-send-email-andy.yan@rock-chips.com>

On Tue, Nov 04, 2014 at 09:33:10PM +0800, Andy Yan wrote:
> From: Andy yan <andy.yan@rock-chips.com>
> 
> We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
> use the interface compatible Designware HDMI IP, but they also have some
> lightly difference, such as phy pll configuration, register width(imx hdmi
> register is one byte, but rk3288 is 4 bytes width and can only access by word),
> 4K support(imx6 doesn't support 4k, but rk3288 does).
> 
> To reuse the imx-hdmi driver, we do this patch set:
> patch (1): split out imx-soc code from imx-hdmi to dw_hdmi-imx.c
> patch (2): move imx-hdmi to bridge/, and rename to dw-hdmi to
> make this driver indepent of drm-imx . And we will add rockchip 
> platform specific code dw_hdmi-rockchip.c later, this is depend
> on drm-rockchip.

Great - I fully agree that this needs to be renamed as it is a Designware
IP.

Should it be moved into bridge/ ?  It isn't implemented as a DRM bridge
driver at present, so this seems illogical.  Is the longer term plan to
convert it to be a DRM bridge?

Secondly, if you want HDMI audio support, you may find the patches I
maintain for the SolidRun devices useful, which add this as a standard
ALSA device.  I also have CEC support for it as well.  If you're
interested, I'll email those.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel