From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v6 04/12] misc: at25: Make use of device property API Date: Tue, 4 Nov 2014 16:38:01 +0200 Message-ID: <20141104143801.GM1618@lahna.fi.intel.com> References: <13750506.S2yVlRRDa2@vostro.rjw.lan> <5019278.RtDq7RlWqt@vostro.rjw.lan> <20141104141826.36F8AC408F6@trevor.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20141104141826.36F8AC408F6-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Grant Likely Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , ACPI Devel Maling List , Greg Kroah-Hartman , Darren Hart , Aaron Lu , Arnd Bergmann , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linus Walleij , Alexandre Courbot , Dmitry Torokhov , Bryan Wu List-Id: devicetree@vger.kernel.org On Tue, Nov 04, 2014 at 02:18:26PM +0000, Grant Likely wrote: > > - strncpy(chip->name, np->name, sizeof(chip->name)); > > + strncpy(chip->name, "at25", sizeof(chip->name)); > > This line changes behaviour of the driver. It's possibly not a problem, > but it should be commented on and whether any due diligance has been > done to make sure it there isn't anything that depends on it. I found only one user for "atmel,at25" in any of the DT sample files. arch/arm/boot/dts/phy3250.dts: eeprom: at25@0 { ... at25,byte-len = <0x8000>; at25,addr-mode = <2>; at25,page-size = <64>; compatible = "atmel,at25"; reg = <0>; spi-max-frequency = <5000000>; }; I think np->name is "at25" in this case? The binding file Documentation/devicetree/bindings/misc/at25.txt also has the same name. Are you OK, if we add something like below to the changelog? In addition we hard-code the name of the chip to be "at25" for the reason that there is no common mechanism to fetch name of the firmware node. The only existing user (arch/arm/boot/dts/phy3250.dts) uses the same name so it should continue to work. > Otherwise: > Acked-by: Grant Likely Thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html