From: Johan Hovold <johan@kernel.org>
To: Romain Perier <romain.perier@gmail.com>
Cc: heiko@sntech.de, grant.likely@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, lgirdwood@gmail.com,
broonie@kernel.org, johan@kernel.org, mark.rutland@arm.com,
linux-pm@vger.kernel.org, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH 0/4] poweroff-source DT property renaming
Date: Wed, 5 Nov 2014 10:39:12 +0100 [thread overview]
Message-ID: <20141105093912.GM31358@localhost> (raw)
In-Reply-To: <1414568135-8311-1-git-send-email-romain.perier@gmail.com>
On Wed, Oct 29, 2014 at 07:35:31AM +0000, Romain Perier wrote:
> The goal of this serie is to rename the property "poweroff-source" to
> "system-power-controller" and to fix things incrementally.
Please mention (here and in the commit message) that this is a rename
back to the old and fairly established property name, but without the
vendor prefix.
Essentially, it is a revert of a commit that is only in the regulator
tree.
> Changes and explanations since v1:
>
> - The first patch defines "of_is_system_power_controller" which is compatible
> with both "vendor,system-power-controller" and "system-power-controller"
> properties. Also, It keeps the old helper function of_system_has_poweroff_source
> for source compatibility until everything is renamed (in this way, bisections
> are not broken and change is made "atomically" between each commit)
>
> Note: the property "poweroff-source" itself is not used in dts files yet.
> Before this patch tps65910 was broken due to missing backward compatibility
> with "vendor,system-power-controller". As the old helper uses the new one,
> it works again.
What patch broke tps65910? Please refer to it using commit id and
summary (in parenthesis).
Is that commit currently only in the regulator tree? If so, that could
be an argument for not doing this change incrementally (but that's not
my decision to make).
>
> - act8865 and tps65910 are ported to the new helper function
>
> - The last commit removes the olf helper which was only used for
> source compatibility
I think you should squash the last three patches (i.e. update the
drivers and remove the helper in one patch).
> Romain Perier (4):
> of: Rename "poweroff-source" property to "system-power-controller"
> regulator: act8865: Convert poweroff-source DT property to
> system-power-controller
> mfd: tps65910: Convert poweroff-source DT property to
> system-power-controller
> of: Remove of_system_has_poweroff_source helper function
Please do not mix patch revisions in your Subject lines when submitting
an updated series. Update the revision number for the series and all
patches in it even if a single patch happens to be unchanged (or new as
patch 4/4).
Johan
next prev parent reply other threads:[~2014-11-05 9:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 7:35 [PATCH 0/4] poweroff-source DT property renaming Romain Perier
2014-10-29 7:35 ` [PATCH v2 1/4] of: Rename "poweroff-source" property to "system-power-controller" Romain Perier
2014-10-30 10:08 ` Romain Perier
2014-11-04 8:21 ` Romain Perier
2014-11-05 9:42 ` Johan Hovold
2014-11-05 10:08 ` Johan Hovold
2014-11-05 16:19 ` Romain Perier
2014-11-05 17:35 ` Grant Likely
2014-10-29 7:35 ` [PATCH v2 2/4] regulator: act8865: Convert poweroff-source DT property to system-power-controller Romain Perier
2014-10-29 7:35 ` [PATCH v2 3/4] mfd: tps65910: " Romain Perier
2014-10-29 7:35 ` [PATCH v1 4/4] of: Remove of_system_has_poweroff_source helper function Romain Perier
2014-10-29 14:21 ` [PATCH 0/4] poweroff-source DT property renaming Romain Perier
2014-11-05 9:39 ` Johan Hovold [this message]
2014-11-05 15:53 ` Romain Perier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105093912.GM31358@localhost \
--to=johan@kernel.org \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).