devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: George Cherian <george.cherian@ti.com>
Cc: myungjoo.ham@samsung.com, cw00.choi@samsung.com,
	robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	rongjun.ying@csr.com, Baohua.Song@csr.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [RESEND PATCH 1/2] extcon: gpio: Add dt support for the driver
Date: Wed, 5 Nov 2014 12:30:26 -0600	[thread overview]
Message-ID: <20141105183026.GC6548@saruman> (raw)
In-Reply-To: <1415201388-32060-2-git-send-email-george.cherian@ti.com>

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

On Wed, Nov 05, 2014 at 08:59:47PM +0530, George Cherian wrote:
> Add device tree support to extcon-gpio driver.
> Add devicetree binding documentation
> 
> While at that
> 	- Cleanup the pdata as there are no users for the same.

should be a patch of its own.

> 	- Convert the driver to use gpiod_* API's.

should be a patch of its own.

> 	- Some gpio's can sleep while reading, so always use gpio_get_value_cansleep

doesn't explain the fact that you have such a platform. Make it clear
that you have a platform supported in mainline which uses a GPIO from an
external i2c I/O expander and because of that you need to use can_sleep.

Should also be a patch of its own, as it was before.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-11-05 18:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05 15:29 [RESEND PATCH 0/2] Add dt support for extcon gpio driver George Cherian
2014-11-05 15:29 ` [RESEND PATCH 1/2] extcon: gpio: Add dt support for the driver George Cherian
2014-11-05 18:30   ` Felipe Balbi [this message]
2014-11-12  1:10   ` Chanwoo Choi
2014-11-05 15:29 ` [RESEND PATCH 2/2] extcon: gpio: Add support for using cable names George Cherian
2014-11-12  1:12   ` Chanwoo Choi
     [not found] ` <1415201388-32060-1-git-send-email-george.cherian-l0cyMroinI0@public.gmane.org>
2014-11-06  1:14   ` [RESEND PATCH 0/2] Add dt support for extcon gpio driver Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141105183026.GC6548@saruman \
    --to=balbi@ti.com \
    --cc=Baohua.Song@csr.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=george.cherian@ti.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=rongjun.ying@csr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).