devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>
Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
	Philipp Zabel
	<philipp.zabel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc
Date: Wed, 5 Nov 2014 13:50:15 -0600	[thread overview]
Message-ID: <20141105195015.GU6548@saruman> (raw)
In-Reply-To: <87sihx1lcd.fsf-GANU6spQydw@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

On Wed, Nov 05, 2014 at 08:46:58PM +0100, Robert Jarzmik wrote:
> Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> writes:
> 
> > Hi,
> >
> > On Sun, Nov 02, 2014 at 07:11:49PM +0100, Robert Jarzmik wrote:
> >> In order to prepare device-tree conversion, port gpio_vbus to use
> >> gpio_desc.
> >> 
> >> Signed-off-by: Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>
> >
> > Can we just convert users of this to a phy-generic.c with a regulator ?
> Maybe, let's see what is missing.
> 
> > This is basically what gpio-vbus is doing, it's basically a regulator.
> And a detector too. The basic thing is that it request an interrupt, and upon
> this interrupt it schedules through a workqueue a usb_gadget_vbus_connect() and
> the regulator stuff.
> 
> I don't see the interrupt+ usb_gadget_vbus_connect() stuff that in the
> phy-generic. Am I missing something ?

Well, let's add that :-) Just make it optional. It's pointless to have
80% duplicated code just because of 20% missing in phy-generic :-)

Then we avoid adding gpio-vbus specific DT properties too.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2014-11-05 19:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-02 18:11 [PATCH v1 1/3] usb: phy: device-tree documentation for gpio-vbus Robert Jarzmik
     [not found] ` <1414951910-16075-1-git-send-email-robert.jarzmik-GANU6spQydw@public.gmane.org>
2014-11-02 18:11   ` [PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc Robert Jarzmik
     [not found]     ` <1414951910-16075-2-git-send-email-robert.jarzmik-GANU6spQydw@public.gmane.org>
2014-11-04  8:01       ` Philipp Zabel
2014-11-05 19:29       ` Felipe Balbi
2014-11-05 19:46         ` Robert Jarzmik
     [not found]           ` <87sihx1lcd.fsf-GANU6spQydw@public.gmane.org>
2014-11-05 19:50             ` Felipe Balbi [this message]
2014-11-05 20:02               ` Robert Jarzmik
     [not found]                 ` <87oasl1kn7.fsf-GANU6spQydw@public.gmane.org>
2014-11-05 20:09                   ` Felipe Balbi
2014-11-08 17:45                     ` Robert Jarzmik
     [not found]                       ` <87a941wppk.fsf-GANU6spQydw@public.gmane.org>
2014-11-08 18:06                         ` Felipe Balbi
2014-11-02 18:11   ` [PATCH v1 3/3] usb: phy: add device-tree support for gpio-vbus Robert Jarzmik
     [not found]     ` <1414951910-16075-3-git-send-email-robert.jarzmik-GANU6spQydw@public.gmane.org>
2014-11-04  8:28       ` Philipp Zabel
2014-11-05 19:31       ` Felipe Balbi
2014-11-04  8:20   ` [PATCH v1 1/3] usb: phy: device-tree documentation " Philipp Zabel
     [not found]     ` <CA+gwMcco4-aOHd4tQRFkUts+C9G5+ymxEhGXYB_FaeuBLQSBrw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-04 21:27       ` Robert Jarzmik
2014-11-05 12:59   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141105195015.GU6548@saruman \
    --to=balbi-l0cymroini0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=philipp.zabel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=robert.jarzmik-GANU6spQydw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).