[PATCH 0/3] ARM: dts: AM43x: Fix DCDC3 regulator voltage

[PATCH 0/3] ARM: dts: AM43x: Fix DCDC3 regulator voltage

[Keerthy]

Fix DCDC3 volatge to 1.5V which is the right value to be supplied by
DCDC3 for all the boards.

Keerthy (3):
  ARM: dts: AM43x-EPOS-EVM: Fix DCDC3 voltage
  ARM: dts: AM437x-GP-EVM: Fix DCDC3 voltage
  ARM: dts: AM437x-SK-EVM: Fix DCDC3 voltage

 arch/arm/boot/dts/am437x-gp-evm.dts  |    4 ++--
 arch/arm/boot/dts/am437x-sk-evm.dts  |    4 ++--
 arch/arm/boot/dts/am43x-epos-evm.dts |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

-- 
1.7.9.5

[PATCH 1/3] ARM: dts: AM43x-EPOS-EVM: Fix DCDC3 voltage

[Keerthy]

DCDC3 supplies voltage to DDR. Fix DCDC3 volatge to 1.5V which is the reset
value. Programming to a non-reset value while executing from DDR will result
in random hangs.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/boot/dts/am43x-epos-evm.dts |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
index ac3e485..f7e9bba 100644
--- a/arch/arm/boot/dts/am43x-epos-evm.dts
+++ b/arch/arm/boot/dts/am43x-epos-evm.dts
@@ -358,8 +358,8 @@
 		dcdc3: regulator-dcdc3 {
 			compatible = "ti,tps65218-dcdc3";
 			regulator-name = "vdcdc3";
-			regulator-min-microvolt = <1350000>;
-			regulator-max-microvolt = <1350000>;
+			regulator-min-microvolt = <1500000>;
+			regulator-max-microvolt = <1500000>;
 			regulator-boot-on;
 			regulator-always-on;
 		};
-- 
1.7.9.5

[PATCH 2/3] ARM: dts: AM437x-GP-EVM: Fix DCDC3 voltage

[Keerthy]

DCDC3 supplies voltage to DDR. Fix DCDC3 volatge to 1.5V which is the reset 
value. Programming to a non-reset value while executing from DDR will result
in random hangs.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index e7ac47f..a521ac0 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -291,8 +291,8 @@
 		dcdc3: regulator-dcdc3 {
 			compatible = "ti,tps65218-dcdc3";
 			regulator-name = "vdcdc3";
-			regulator-min-microvolt = <1350000>;
-			regulator-max-microvolt = <1350000>;
+			regulator-min-microvolt = <1500000>;
+			regulator-max-microvolt = <1500000>;
 			regulator-boot-on;
 			regulator-always-on;
 		};
-- 
1.7.9.5

[PATCH 3/3] ARM: dts: AM437x-SK-EVM: Fix DCDC3 voltage

[Keerthy]

DCDC3 supplies voltage to DDR. Fix DCDC3 volatge to 1.5V which is the reset 
value. Programming to a non-reset value while executing from DDR will result
in random hangs.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/boot/dts/am437x-sk-evm.dts |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
index 859ff3d..87aa4f3 100644
--- a/arch/arm/boot/dts/am437x-sk-evm.dts
+++ b/arch/arm/boot/dts/am437x-sk-evm.dts
@@ -363,8 +363,8 @@
 		dcdc3: regulator-dcdc3 {
 			compatible = "ti,tps65218-dcdc3";
 			regulator-name = "vdds_ddr";
-			regulator-min-microvolt = <1350000>;
-			regulator-max-microvolt = <1350000>;
+			regulator-min-microvolt = <1500000>;
+			regulator-max-microvolt = <1500000>;
 			regulator-boot-on;
 			regulator-always-on;
 		};
-- 
1.7.9.5

Re: [PATCH 0/3] ARM: dts: AM43x: Fix DCDC3 regulator voltage

[Nishanth Menon]

On 11/06/2014 04:50 AM, Keerthy wrote:
> Fix DCDC3 volatge to 1.5V which is the right value to be supplied by
> DCDC3 for all the boards.
> 
> Keerthy (3):
>   ARM: dts: AM43x-EPOS-EVM: Fix DCDC3 voltage
>   ARM: dts: AM437x-GP-EVM: Fix DCDC3 voltage
>   ARM: dts: AM437x-SK-EVM: Fix DCDC3 voltage
> 
>  arch/arm/boot/dts/am437x-gp-evm.dts  |    4 ++--
>  arch/arm/boot/dts/am437x-sk-evm.dts  |    4 ++--
>  arch/arm/boot/dts/am43x-epos-evm.dts |    4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
If Tony suggests, we might want to squash these to a single patch
since it hits every AM437x evm platform... but anyways..

Acked-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon

Re: [PATCH 0/3] ARM: dts: AM43x: Fix DCDC3 regulator voltage

[Tony Lindgren]

* Keerthy <j-keerthy@ti.com> [141106 02:55]:
> Fix DCDC3 volatge to 1.5V which is the right value to be supplied by
> DCDC3 for all the boards.

Hmm so what about the comments for similar beaglebone changes
in thread "[PATCH] ARM: dts: am335x-boneblack: set dcdc1 regulator
for 1.35v ddr3"?

Regards,

Tony
 
> Keerthy (3):
>   ARM: dts: AM43x-EPOS-EVM: Fix DCDC3 voltage
>   ARM: dts: AM437x-GP-EVM: Fix DCDC3 voltage
>   ARM: dts: AM437x-SK-EVM: Fix DCDC3 voltage
> 
>  arch/arm/boot/dts/am437x-gp-evm.dts  |    4 ++--
>  arch/arm/boot/dts/am437x-sk-evm.dts  |    4 ++--
>  arch/arm/boot/dts/am43x-epos-evm.dts |    4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> -- 
> 1.7.9.5
> 

Re: [PATCH 0/3] ARM: dts: AM43x: Fix DCDC3 regulator voltage

[Robert Nelson]

On Thu, Nov 6, 2014 at 12:25 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Keerthy <j-keerthy@ti.com> [141106 02:55]:
>> Fix DCDC3 volatge to 1.5V which is the right value to be supplied by
>> DCDC3 for all the boards.
>
> Hmm so what about the comments for similar beaglebone changes
> in thread "[PATCH] ARM: dts: am335x-boneblack: set dcdc1 regulator
> for 1.35v ddr3"?

Based on Keerthy's patchset, i think we should just ignore my "1.35v"
ddr3 patch for the beaglebone black. As by default it will be at
1.50v. (so we can either define it for clarity at 1.50v or just ignore
it.)

Keerthy,

Are you guys seeing these same ddr lockups if u-boot correctly set's
the 1.35v level first? Or should we just really leave it at the
default power on voltage level? (till either u-boot or kernel grows
the capabilities to correctly tell the ddr3 we are changing it's
voltage.)

Regards,

-- 
Robert Nelson
http://www.rcn-ee.com/

Re: [PATCH 0/3] ARM: dts: AM43x: Fix DCDC3 regulator voltage

[Keerthy]

On Friday 07 November 2014 12:59 AM, Robert Nelson wrote:
> On Thu, Nov 6, 2014 at 12:25 PM, Tony Lindgren <tony@atomide.com> wrote:
>> * Keerthy <j-keerthy@ti.com> [141106 02:55]:
>>> Fix DCDC3 volatge to 1.5V which is the right value to be supplied by
>>> DCDC3 for all the boards.
>> Hmm so what about the comments for similar beaglebone changes
>> in thread "[PATCH] ARM: dts: am335x-boneblack: set dcdc1 regulator
>> for 1.35v ddr3"?
> Based on Keerthy's patchset, i think we should just ignore my "1.35v"
> ddr3 patch for the beaglebone black. As by default it will be at
> 1.50v. (so we can either define it for clarity at 1.50v or just ignore
> it.)
>
> Keerthy,
>
> Are you guys seeing these same ddr lockups if u-boot correctly set's
> the 1.35v level first? Or should we just really leave it at the
> default power on voltage level? (till either u-boot or kernel grows
> the capabilities to correctly tell the ddr3 we are changing it's
> voltage.)

Robert,

In our case even u-boot lets it to be at 1.5V. The problem is
when the regulators are registered we try to set it 1.35V since
that is what we are passing from device tree. I see lock up
on the latest boards we have.

Regards,
Keerthy


>
> Regards,
>

Re: [PATCH 0/3] ARM: dts: AM43x: Fix DCDC3 regulator voltage

[Keerthy]

On Friday 07 November 2014 10:56 AM, Keerthy wrote:
> On Friday 07 November 2014 12:59 AM, Robert Nelson wrote:
>> On Thu, Nov 6, 2014 at 12:25 PM, Tony Lindgren <tony@atomide.com> wrote:
>>> * Keerthy <j-keerthy@ti.com> [141106 02:55]:
>>>> Fix DCDC3 volatge to 1.5V which is the right value to be supplied by
>>>> DCDC3 for all the boards.
>>> Hmm so what about the comments for similar beaglebone changes
>>> in thread "[PATCH] ARM: dts: am335x-boneblack: set dcdc1 regulator
>>> for 1.35v ddr3"?
>> Based on Keerthy's patchset, i think we should just ignore my "1.35v"
>> ddr3 patch for the beaglebone black. As by default it will be at
>> 1.50v. (so we can either define it for clarity at 1.50v or just ignore
>> it.)
>>
>> Keerthy,
>>
>> Are you guys seeing these same ddr lockups if u-boot correctly set's
>> the 1.35v level first? Or should we just really leave it at the
>> default power on voltage level? (till either u-boot or kernel grows
>> the capabilities to correctly tell the ddr3 we are changing it's
>> voltage.)
>
> Robert,
>
> In our case even u-boot lets it to be at 1.5V. The problem is
> when the regulators are registered we try to set it 1.35V since
> that is what we are passing from device tree. I see lock up
> on the latest boards we have.

The issue is seen when we are executing from DDR and the voltage is changed
(in our case lowered) on the fly.

>
> Regards,
> Keerthy
>
>
>>
>> Regards,
>>
>

Re: [PATCH 0/3] ARM: dts: AM43x: Fix DCDC3 regulator voltage

[Tony Lindgren]

* Robert Nelson <robertcnelson@gmail.com> [141106 11:31]:
> On Thu, Nov 6, 2014 at 12:25 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Keerthy <j-keerthy@ti.com> [141106 02:55]:
> >> Fix DCDC3 volatge to 1.5V which is the right value to be supplied by
> >> DCDC3 for all the boards.
> >
> > Hmm so what about the comments for similar beaglebone changes
> > in thread "[PATCH] ARM: dts: am335x-boneblack: set dcdc1 regulator
> > for 1.35v ddr3"?
> 
> Based on Keerthy's patchset, i think we should just ignore my "1.35v"
> ddr3 patch for the beaglebone black. As by default it will be at
> 1.50v. (so we can either define it for clarity at 1.50v or just ignore
> it.)

OK thanks. I'll apply these into omap-for-v3.18/fixes and ignore
your beaglebone black patch.

Regards,

Tony

Re: [PATCH 0/3] ARM: dts: AM43x: Fix DCDC3 regulator voltage

[Keerthy]

On Thursday 06 November 2014 11:55 PM, Tony Lindgren wrote:
> * Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org> [141106 02:55]:
>> Fix DCDC3 volatge to 1.5V which is the right value to be supplied by
>> DCDC3 for all the boards.
> Hmm so what about the comments for similar beaglebone changes
> in thread "[PATCH] ARM: dts: am335x-boneblack: set dcdc1 regulator
> for 1.35v ddr3"?
Hi Tony,

am335x uses TPS65917 PMIC and am43x* use TPS65218 PMIC.
The latest TPS65218 defaults to 1.5V. We see boot hangs when
there is a voltage change from 1.5V to 1.35V in case of AM43x
boards. Hence keeping it at 1.5V.

Regards,
Keerthy
>
> Regards,
>
> Tony
>   
>> Keerthy (3):
>>    ARM: dts: AM43x-EPOS-EVM: Fix DCDC3 voltage
>>    ARM: dts: AM437x-GP-EVM: Fix DCDC3 voltage
>>    ARM: dts: AM437x-SK-EVM: Fix DCDC3 voltage
>>
>>   arch/arm/boot/dts/am437x-gp-evm.dts  |    4 ++--
>>   arch/arm/boot/dts/am437x-sk-evm.dts  |    4 ++--
>>   arch/arm/boot/dts/am43x-epos-evm.dts |    4 ++--
>>   3 files changed, 6 insertions(+), 6 deletions(-)
>>
>> -- 
>> 1.7.9.5
>>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] ARM: dts: AM43x: Fix DCDC3 regulator voltage

[Keerthy]

On Friday 07 November 2014 10:16 AM, Keerthy wrote:
> On Thursday 06 November 2014 11:55 PM, Tony Lindgren wrote:
>> * Keerthy <j-keerthy@ti.com> [141106 02:55]:
>>> Fix DCDC3 volatge to 1.5V which is the right value to be supplied by
>>> DCDC3 for all the boards.
>> Hmm so what about the comments for similar beaglebone changes
>> in thread "[PATCH] ARM: dts: am335x-boneblack: set dcdc1 regulator
>> for 1.35v ddr3"?
> Hi Tony,
>
> am335x uses TPS65917 PMIC and am43x* use TPS65218 PMIC.

Typo TPS65917--->TPS65217

> The latest TPS65218 defaults to 1.5V. We see boot hangs when
> there is a voltage change from 1.5V to 1.35V in case of AM43x
> boards. Hence keeping it at 1.5V.
>
> Regards,
> Keerthy
>>
>> Regards,
>>
>> Tony
>>> Keerthy (3):
>>>    ARM: dts: AM43x-EPOS-EVM: Fix DCDC3 voltage
>>>    ARM: dts: AM437x-GP-EVM: Fix DCDC3 voltage
>>>    ARM: dts: AM437x-SK-EVM: Fix DCDC3 voltage
>>>
>>>   arch/arm/boot/dts/am437x-gp-evm.dts  |    4 ++--
>>>   arch/arm/boot/dts/am437x-sk-evm.dts  |    4 ++--
>>>   arch/arm/boot/dts/am43x-epos-evm.dts |    4 ++--
>>>   3 files changed, 6 insertions(+), 6 deletions(-)
>>>
>>> -- 
>>> 1.7.9.5
>>>
>