From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Magnus Damm <magnus.damm@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
alsa-devel@alsa-project.org, linux-sh@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/5] ASoC: rsnd: Document SoC-specific bindings
Date: Tue, 11 Nov 2014 09:25:18 +0900 [thread overview]
Message-ID: <20141111002517.GF29665@verge.net.au> (raw)
In-Reply-To: <1415646044-4168-4-git-send-email-geert+renesas@glider.be>
On Mon, Nov 10, 2014 at 08:00:42PM +0100, Geert Uytterhoeven wrote:
> The documentation only mentioned the generic fallback compatible
> property.
> Add the missing SoC-specific compatible properties, which are already in
> use.
>
> Also drop a bogus 0x unit-address prefix while we're at it.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> Documentation/devicetree/bindings/sound/renesas,rsnd.txt | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
> index aa697abf337e7aa6..2dd690bc19cc6436 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
> @@ -1,8 +1,12 @@
> Renesas R-Car sound
>
> Required properties:
> -- compatible : "renesas,rcar_sound-gen1" if generation1
> +- compatible : "renesas,rcar_sound-<soctype>", fallbacks
> + "renesas,rcar_sound-gen1" if generation1, and
> "renesas,rcar_sound-gen2" if generation2
> + Examples with soctypes are:
> + - "renesas,rcar_sound-r8a7790" (R-Car H2)
> + - "renesas,rcar_sound-r8a7791" (R-Car M2-W)
> - reg : Should contain the register physical address.
> required register is
> SRU/ADG/SSI if generation1
> @@ -35,9 +39,9 @@ DAI subnode properties:
>
> Example:
>
> -rcar_sound: rcar_sound@0xffd90000 {
> +rcar_sound: rcar_sound@ec500000 {
> #sound-dai-cells = <1>;
> - compatible = "renesas,rcar_sound-gen2";
> + compatible = "renesas,rcar_sound-r8a7791", "renesas,rcar_sound-gen2";
> reg = <0 0xec500000 0 0x1000>, /* SCU */
> <0 0xec5a0000 0 0x100>, /* ADG */
> <0 0xec540000 0 0x1000>, /* SSIU */
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-11-11 0:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 19:00 [PATCH 0/5] ARM: shmobile: Sound binding updates Geert Uytterhoeven
2014-11-10 19:00 ` [PATCH 1/5] ASoC: sh: fsi: Document SoC-specific bindings Geert Uytterhoeven
2014-11-11 0:24 ` Simon Horman
2014-11-12 22:31 ` Mark Brown
2014-11-10 19:00 ` [PATCH 2/5] ARM: shmobile: sh73a0 dtsi: Add SoC-specific FSI2 compatible property Geert Uytterhoeven
2014-11-10 19:00 ` [PATCH 3/5] ASoC: rsnd: Document SoC-specific bindings Geert Uytterhoeven
2014-11-11 0:25 ` Simon Horman [this message]
2014-11-12 22:31 ` Mark Brown
2014-11-10 19:00 ` [PATCH 4/5] ARM: shmobile: r8a7790 dtsi: Drop "renesas,rcar_sound" compatible value Geert Uytterhoeven
2014-11-10 19:00 ` [PATCH 5/5] ARM: shmobile: r8a7791 " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111002517.GF29665@verge.net.au \
--to=horms@verge.net.au \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).