From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [RFCv2 1/8] [media] si4713: switch to devm regulator API Date: Tue, 11 Nov 2014 20:12:26 -0200 Message-ID: <20141111201226.5d824871@recife.lan> References: <1413904027-16767-1-git-send-email-sre@kernel.org> <1413904027-16767-2-git-send-email-sre@kernel.org> <20141111090710.7a60a846@recife.lan> <54624E83.1060404@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <54624E83.1060404-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hans Verkuil Cc: Sebastian Reichel , Hans Verkuil , linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tony Lindgren , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Em Tue, 11 Nov 2014 18:59:31 +0100 Hans Verkuil escreveu: > Hi Mauro, >=20 > On 11/11/2014 12:07 PM, Mauro Carvalho Chehab wrote: > > Em Tue, 21 Oct 2014 17:07:00 +0200 > > Sebastian Reichel escreveu: > >=20 > >> This switches back to the normal regulator API (but use > >> managed variant) in preparation for device tree support. > >=20 > > This patch broke compilation. Please be sure that none of the patch= es in > > the series would break it, as otherwise git bisect would be broken. >=20 > Weird, as reported by Sebastian, it works for me. Weird. Not sure what happened here. >=20 > However, after applying this patch I get these new warnings: >=20 > CC drivers/media/radio/si4713/radio-usb-si4713.o > drivers/media/radio/si4713/si4713.c: In function =E2=80=98si4713_prob= e=E2=80=99: > drivers/media/radio/si4713/si4713.c:1617:1: warning: label =E2=80=98f= ree_gpio=E2=80=99 defined but not used [-Wunused-label] > free_gpio: > ^ > drivers/media/radio/si4713/si4713.c:1451:12: warning: unused variable= =E2=80=98i=E2=80=99 [-Wunused-variable] > int rval, i; > ^ >=20 > So it's probably not a good idea to merge this patch anyway until thi= s is fixed. Agreed. Also, v3 of this series apparently came after the pull request. Regards, Mauro > Sebastian, can you fix these warnings and repost? >=20 > Thanks! >=20 > Hans >=20 > >=20 > > Thanks, > > Mauro > >=20 > > drivers/media/radio/si4713/si4713.c: In function 'si4713_powerup': > > drivers/media/radio/si4713/si4713.c:369:10: error: 'struct si4713_d= evice' has no member named 'supplies' > > =20 > > ^ > > drivers/media/radio/si4713/si4713.c:370:35: error: 'struct si4713_d= evice' has no member named 'supplies' > > if (sdev->vdd) { > > ^ > > drivers/media/radio/si4713/si4713.c:370:51: error: 'struct si4713_d= evice' has no member named 'supply_data' > > if (sdev->vdd) { > > ^ > > drivers/media/radio/si4713/si4713.c:402:10: error: 'struct si4713_d= evice' has no member named 'supplies' > > v4l2_dbg(1, debug, &sdev->sd, "Device in power up mode\n"); > > ^ > > drivers/media/radio/si4713/si4713.c:403:36: error: 'struct si4713_d= evice' has no member named 'supplies' > > sdev->power_state =3D POWER_ON; > > ^ > > drivers/media/radio/si4713/si4713.c:403:52: error: 'struct si4713_d= evice' has no member named 'supply_data' > > sdev->power_state =3D POWER_ON; > > ^ > > drivers/media/radio/si4713/si4713.c: In function 'si4713_powerdown'= : > > drivers/media/radio/si4713/si4713.c:435:11: error: 'struct si4713_d= evice' has no member named 'supplies' > > int err; > > ^ > > drivers/media/radio/si4713/si4713.c:436:37: error: 'struct si4713_d= evice' has no member named 'supplies' > > u8 resp[SI4713_PWDN_NRESP]; > > ^ > > drivers/media/radio/si4713/si4713.c:437:16: error: 'struct si4713_d= evice' has no member named 'supply_data' > > =20 > > ^ > > drivers/media/radio/si4713/si4713.c: In function 'si4713_probe': > > drivers/media/radio/si4713/si4713.c:1444:7: error: 'struct si4713_d= evice' has no member named 'supplies' > > /* si4713_probe - probe for the device */ > > ^ > > drivers/media/radio/si4713/si4713.c:1447:22: error: 'struct si4713_= device' has no member named 'supplies' > > { > > ^ > > drivers/media/radio/si4713/si4713.c:1448:7: error: 'struct si4713_d= evice' has no member named 'supply_data' > > struct si4713_device *sdev; > > ^ > > drivers/media/radio/si4713/si4713.c:1450:46: error: 'struct si4713_= device' has no member named 'supplies' > > struct v4l2_ctrl_handler *hdl; > > ^ > > drivers/media/radio/si4713/si4713.c:1451:11: error: 'struct si4713_= device' has no member named 'supply_data' > > int rval, i; > > ^ > > drivers/media/radio/si4713/si4713.c:1583:26: error: 'struct si4713_= device' has no member named 'supplies' > > =20 > > ^ > > drivers/media/radio/si4713/si4713.c:1583:42: error: 'struct si4713_= device' has no member named 'supply_data' > > =20 > > ^ > > drivers/media/radio/si4713/si4713.c: In function 'si4713_remove': > > drivers/media/radio/si4713/si4713.c:1607:26: error: 'struct si4713_= device' has no member named 'supplies' > > goto free_irq; > > ^ > > drivers/media/radio/si4713/si4713.c:1607:42: error: 'struct si4713_= device' has no member named 'supply_data' > > goto free_irq; > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-med= ia" in > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > >=20 >=20 -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html