From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH 3/3] ARM: dts: vf-colibri: add USB regulators Date: Thu, 13 Nov 2014 09:23:59 +0800 Message-ID: <20141113012358.GN2704@dragon> References: <1415106430-6271-1-git-send-email-stefan@agner.ch> <1415106430-6271-4-git-send-email-stefan@agner.ch> <20141111141228.GB2704@dragon> <0bb62bdfc866f75977d01070d228ed4c@agner.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <0bb62bdfc866f75977d01070d228ed4c-XLVq0VzYD2Y@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stefan Agner Cc: kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Nov 12, 2014 at 04:51:16PM +0100, Stefan Agner wrote: > >> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi > >> index 2371760..79ccfe2 100644 > >> --- a/arch/arm/boot/dts/vf-colibri.dtsi > >> +++ b/arch/arm/boot/dts/vf-colibri.dtsi > >> @@ -163,5 +163,17 @@ > >> VF610_PAD_PTD3__UART2_CTS 0x21a1 > >> >; > >> }; > >> + > >> + pinctrl_usbh1_ext: gpio_usb_vbus { > >> + fsl,pins = < > >> + VF610_PAD_PTD4__GPIO_83 0x22ed > > > > We used to know the GPIO usage by looking for the phandle reference to > > the node. But it doesn't work for VF610 case now. > > > > I guess this is for usbh_vbus_reg usage? It would be nice to have a > > comment telling the usage of the GPIO. > > Yeah its true, its assign is not required for Vybird. However, we could > assign them anyway, it would even enforce correct pin setup from > Startup... This would then make a comment superfluous. What do you > think? I agree with the approach of assigning the phandle anyway. > > > > > >> + >; > >> + }; > >> + > >> + pinctrl_usbdev0_ext: gpio_usb_cdet { > >> + fsl,pins = < > >> + VF610_PAD_PTC29__GPIO_102 0x22ed > > > > How is this one used? > > This is not yet used. It is more or less the OTG-ID pin, but on 3.3V > level. We use that on the Colibri standard to switch between Host/Device > mode, however a driver which uses that GPIO is still outstanding. I can > also leave that away for now, if you prefer.... Then let's add it when it's actually required. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html