devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Roger Quadros <rogerq@ti.com>
Cc: tony@atomide.com, wg@grandegger.com, mkl@pengutronix.de,
	mugunthanvnm@ti.com, george.cherian@ti.com, balbi@ti.com,
	nsekhar@ti.comnm@ti.com, sergei.shtylyov@cogentembedded.com,
	linux-omap@vger.kernel.org, linux-can@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 09/10] ARM: dts: am33xx: Update DCAN nodes
Date: Thu, 13 Nov 2014 17:03:49 +0100	[thread overview]
Message-ID: <20141113160349.GA1275@katana> (raw)
In-Reply-To: <1415881371-4982-10-git-send-email-rogerq@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]

On Thu, Nov 13, 2014 at 02:22:50PM +0200, Roger Quadros wrote:
> Add "raminit-syscon" property to specify the RAMINIT register.
> Add clock information.
> Rename can nodes from "d_can" to "can" to be compliant
> with the ePAPR specs.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  arch/arm/boot/dts/am33xx.dtsi | 20 ++++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 9f3058c..74fefa1 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -338,20 +338,24 @@
>  			interrupts = <91>;
>  		};
>  
> -		dcan0: d_can@481cc000 {
> -			compatible = "bosch,d_can";
> +		dcan0: can@481cc000 {
> +			compatible = "ti,am3352-d_can";
>  			ti,hwmods = "d_can0";
> -			reg = <0x481cc000 0x2000
> -				0x44e10644 0x4>;
> +			reg = <0x481cc000 0x2000>;
> +			clocks = <&dcan0_fck>;
> +			clock-names = "fck";
> +			syscon-raminit = <&am33xx_control_module 0x644 0>;

Yeah, I missed to write the mail that I disagreed with the "dcan_0/1"
compatible-properties of V3. The second parameter to syscon here is much
better!

Acked-by: Wolfram Sang <wsa@the-dreams.de>


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-11-13 16:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13 12:22 [PATCH v4 00/10] ARM: dts: TI: Add CAN support Roger Quadros
2014-11-13 12:22 ` [PATCH v4 01/10] ARM: dts: dra7: Add syscon regmap for CORE CONTROL area Roger Quadros
2014-11-13 12:22 ` [PATCH v4 02/10] ARM: dts: DRA7: Add DCAN nodes Roger Quadros
2014-11-13 12:22 ` [PATCH v4 03/10] ARM: dts: dra7-evm: Add CAN support Roger Quadros
2014-11-13 12:22 ` [PATCH v4 04/10] ARM: dts: dra72-evm: " Roger Quadros
2014-11-13 12:22 ` [PATCH v4 05/10] ARM: dts: am4372: Add control module syscon node Roger Quadros
2014-11-13 12:22 ` [PATCH v4 06/10] ARM: dts: am4372: Add DCAN nodes Roger Quadros
2014-11-13 14:07   ` Marc Kleine-Budde
2014-11-13 14:40     ` Roger Quadros
2014-11-13 14:44       ` Marc Kleine-Budde
2014-11-13 14:49         ` Roger Quadros
2014-11-13 14:54           ` Marc Kleine-Budde
2014-11-13 17:40             ` Tony Lindgren
2014-11-14 16:22               ` Roger Quadros
2014-11-14 18:07                 ` Tony Lindgren
2014-11-17 13:08   ` [PATCH v5 " Roger Quadros
2014-11-21 23:50     ` Tony Lindgren
2014-11-22  0:08       ` Tony Lindgren
2014-11-24  9:58         ` Roger Quadros
2014-11-24 11:11           ` Roger Quadros
2014-11-24 15:49             ` Tony Lindgren
2014-11-24 16:05               ` Tony Lindgren
2014-11-13 12:22 ` [PATCH v4 07/10] arm: dts: am437x-gp: Add dcan support Roger Quadros
2014-11-13 12:22 ` [PATCH v4 08/10] ARM: dts: am33xx: Add control module syscon node Roger Quadros
2014-11-13 12:22 ` [PATCH v4 09/10] ARM: dts: am33xx: Update DCAN nodes Roger Quadros
2014-11-13 16:03   ` Wolfram Sang [this message]
2014-11-13 12:22 ` [PATCH v4 10/10] ARM: dts: am335x-evm: Add DCAN1 details Roger Quadros
2014-11-18 20:42 ` [PATCH v4 00/10] ARM: dts: TI: Add CAN support Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141113160349.GA1275@katana \
    --to=wsa@the-dreams.de \
    --cc=balbi@ti.com \
    --cc=george.cherian@ti.com \
    --cc=mkl@pengutronix.de \
    --cc=mugunthanvnm@ti.com \
    --cc=nsekhar@ti.comnm \
    --cc=rogerq@ti.com \
    --cc=tony@atomide.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).