"ak" vs "asahi-kasei" (was: Re: [PATCH 3/3 v3] ARM: shmobile: lager: add sound support on DT)

"ak" vs "asahi-kasei" (was: Re: [PATCH 3/3 v3] ARM: shmobile: lager: add sound support on DT)

[Geert Uytterhoeven]

Hi Morimoto-san,

CC devicetree, alsa-devel

On Wed, Jun 11, 2014 at 9:40 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>> On Wed, Jun 11, 2014 at 8:54 AM, Kuninori Morimoto
>> <kuninori.morimoto.gx@renesas.com> wrote:
>> > +               compatible = "asahi-kasei,ak4643";
>>
>> As Sergei already commented,
>> Documentation/devicetree/bindings/vendor-prefixes.txt
>> says
>>
>>         ak      Asahi Kasei Corp.
>
> I know, but,
>
> grep asahi-kasei sound/soc/codecs/*
> sound/soc/codecs/ak4104.c:      { .compatible = "asahi-kasei,ak4104", },
> sound/soc/codecs/ak4554.c:      { .compatible = "asahi-kasei,ak4554" },
> sound/soc/codecs/ak4642.c:      { .compatible = "asahi-kasei,ak4642",   .data = &ak4642_drvdata},
> sound/soc/codecs/ak4642.c:      { .compatible = "asahi-kasei,ak4643",   .data = &ak4643_drvdata},
> sound/soc/codecs/ak4642.c:      { .compatible = "asahi-kasei,ak4648",   .data = &ak4648_drvdata},
> sound/soc/codecs/ak5386.c:      { .compatible = "asahi-kasei,ak5386", },
>
> ak4642 driver can't probe by "ak";

That's bad. And all but one of these match entries have been added
_after_ the addition of "ak" to vendor-prefixes.txt...

Outside sound, there's also "asahi-kasei,ak8975" vs. "ak,ak8975".

> My code is based on "code", not "document"

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [alsa-devel] "ak" vs "asahi-kasei" (was: Re: [PATCH 3/3 v3] ARM: shmobile: lager: add sound support on DT)

[Kuninori Morimoto]

Hi Geert

> > grep asahi-kasei sound/soc/codecs/*
> > sound/soc/codecs/ak4104.c:      { .compatible = "asahi-kasei,ak4104", },
> > sound/soc/codecs/ak4554.c:      { .compatible = "asahi-kasei,ak4554" },
> > sound/soc/codecs/ak4642.c:      { .compatible = "asahi-kasei,ak4642",   .data = &ak4642_drvdata},
> > sound/soc/codecs/ak4642.c:      { .compatible = "asahi-kasei,ak4643",   .data = &ak4643_drvdata},
> > sound/soc/codecs/ak4642.c:      { .compatible = "asahi-kasei,ak4648",   .data = &ak4648_drvdata},
> > sound/soc/codecs/ak5386.c:      { .compatible = "asahi-kasei,ak5386", },
> >
> > ak4642 driver can't probe by "ak";
> 
> That's bad. And all but one of these match entries have been added
> _after_ the addition of "ak" to vendor-prefixes.txt...
> 
> Outside sound, there's also "asahi-kasei,ak8975" vs. "ak,ak8975".

In my quick check,
The driver which is supporting "ak" is only ak8975.
Other Asahi-Kasei driver is using "asahi-kasei".

Very interesting is that the document of ak8975
./Documentation/devicetree/bindings/iio/magnetometer/ak8975.txt
said it should be "asahi-kasei"

what is the policy of Documentation/devicetree/bindings/vendor-prefixes.txt ?

-----------------------------------------------
grep compatible `find | grep ".*/ak"`
./arch/arm/boot/dts/aks-cdu.dts:                compatible = "gpio-leds";
./drivers/iio/magnetometer/ak8975.c:    { .compatible = "asahi-kasei,ak8975", },
./drivers/iio/magnetometer/ak8975.c:    { .compatible = "ak8975", },
./sound/soc/codecs/ak4104.c:    { .compatible = "asahi-kasei,ak4104", },
./sound/soc/codecs/ak5386.c:    { .compatible = "asahi-kasei,ak5386", },
./sound/soc/codecs/ak4554.c:    { .compatible = "asahi-kasei,ak4554" },
./sound/soc/codecs/ak4642.c:    { .compatible = "asahi-kasei,ak4642",   .data = &ak4642_drvdata},
./sound/soc/codecs/ak4642.c:    { .compatible = "asahi-kasei,ak4643",   .data = &ak4643_drvdata},
./sound/soc/codecs/ak4642.c:    { .compatible = "asahi-kasei,ak4648",   .data = &ak4648_drvdata},
./Documentation/devicetree/bindings/iio/magnetometer/ak8975.txt:  - compatible : should be "asahi-kasei,ak8975"
./Documentation/devicetree/bindings/iio/magnetometer/ak8975.txt:        compatible = "asahi-kasei,ak8975";
./Documentation/devicetree/bindings/sound/ak4642.txt:  - compatible : "asahi-kasei,ak4642" or "asahi-kasei,ak4643" or "asahi-kasei,ak4648"
./Documentation/devicetree/bindings/sound/ak4642.txt:           compatible = "asahi-kasei,ak4642";
./Documentation/devicetree/bindings/sound/ak5386.txt:  - compatible : "asahi-kasei,ak5386"
./Documentation/devicetree/bindings/sound/ak5386.txt:   compatible = "asahi-kasei,ak5386";
./Documentation/devicetree/bindings/sound/ak4104.txt:  - compatible : "asahi-kasei,ak4104"
./Documentation/devicetree/bindings/sound/ak4104.txt:   compatible = "asahi-kasei,ak4104";
./Documentation/devicetree/bindings/sound/ak4554.c:  - compatible : "asahi-kasei,ak4554"
./Documentation/devicetree/bindings/sound/ak4554.c:     compatible = "asahi-kasei,ak4554";

Re: [alsa-devel] "ak" vs "asahi-kasei" (was: Re: [PATCH 3/3 v3] ARM: shmobile: lager: add sound support on DT)

[Ben Dooks]

On 11/06/14 09:30, Kuninori Morimoto wrote:
> 
> Hi Geert
> 
>>> grep asahi-kasei sound/soc/codecs/*
>>> sound/soc/codecs/ak4104.c:      { .compatible = "asahi-kasei,ak4104", },
>>> sound/soc/codecs/ak4554.c:      { .compatible = "asahi-kasei,ak4554" },
>>> sound/soc/codecs/ak4642.c:      { .compatible = "asahi-kasei,ak4642",   .data = &ak4642_drvdata},
>>> sound/soc/codecs/ak4642.c:      { .compatible = "asahi-kasei,ak4643",   .data = &ak4643_drvdata},
>>> sound/soc/codecs/ak4642.c:      { .compatible = "asahi-kasei,ak4648",   .data = &ak4648_drvdata},
>>> sound/soc/codecs/ak5386.c:      { .compatible = "asahi-kasei,ak5386", },
>>>
>>> ak4642 driver can't probe by "ak";

Should we add ak, as well?

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

Re: [alsa-devel] "ak" vs "asahi-kasei" (was: Re: [PATCH 3/3 v3] ARM: shmobile: lager: add sound support on DT)

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

On Wed, Jun 11, 2014 at 09:40:06AM +0100, Ben Dooks wrote:
> On 11/06/14 09:30, Kuninori Morimoto wrote:

> >>> ak4642 driver can't probe by "ak";

> Should we add ak, as well?

They're usually referred to as AKM when abbreviated and their web site
is http://www.akm.com/ - don't know what the stock ticker symbol is.  In
any case there's no real cost to adding both abbreviated and
non-abbreviated forms if we want to transition.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [alsa-devel] "ak" vs "asahi-kasei" (was: Re: [PATCH 3/3 v3] ARM: shmobile: lager: add sound support on DT)

[Geert Uytterhoeven]

On Wed, Jun 11, 2014 at 6:54 PM, Mark Brown <broonie@kernel.org> wrote:
> On Wed, Jun 11, 2014 at 09:40:06AM +0100, Ben Dooks wrote:
>> On 11/06/14 09:30, Kuninori Morimoto wrote:
>
>> >>> ak4642 driver can't probe by "ak";
>
>> Should we add ak, as well?
>
> They're usually referred to as AKM when abbreviated and their web site
> is http://www.akm.com/ - don't know what the stock ticker symbol is.  In
> any case there's no real cost to adding both abbreviated and
> non-abbreviated forms if we want to transition.

commit ae8c4209af2cec065fef15d200a42a04130799f7
Author: Stephen Warren <swarren@nvidia.com>
Date:   Mon Nov 19 15:34:43 2012 -0700

    of: Add vendor prefix for Asahi Kasei Corp.

    Their stock ticker is 3407.T which wouldn't make a good DT vendor
    prefix. Use the company name initials instead.

    Signed-off-by: Stephen Warren <swarren@nvidia.com>
    Signed-off-by: Rob Herring <rob.herring@calxeda.com>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [alsa-devel] "ak" vs "asahi-kasei" (was: Re: [PATCH 3/3 v3] ARM: shmobile: lager: add sound support on DT)

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

On Wed, Jun 11, 2014 at 06:57:44PM +0200, Geert Uytterhoeven wrote:
> On Wed, Jun 11, 2014 at 6:54 PM, Mark Brown <broonie@kernel.org> wrote:

> > They're usually referred to as AKM when abbreviated and their web site
> > is http://www.akm.com/ - don't know what the stock ticker symbol is.  In
> > any case there's no real cost to adding both abbreviated and
> > non-abbreviated forms if we want to transition.

>     of: Add vendor prefix for Asahi Kasei Corp.

>     Their stock ticker is 3407.T which wouldn't make a good DT vendor
>     prefix. Use the company name initials instead.

Sounds like akm, is a better bet then, especially as ak, has no real
adoption.  

I think the bikeshed would be much better painted pink with yellow spots :)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [alsa-devel] "ak" vs "asahi-kasei" (was: Re: [PATCH 3/3 v3] ARM: shmobile: lager: add sound support on DT)

[Geert Uytterhoeven]

On Wed, Jun 11, 2014 at 7:02 PM, Mark Brown <broonie@kernel.org> wrote:
> On Wed, Jun 11, 2014 at 06:57:44PM +0200, Geert Uytterhoeven wrote:
>> On Wed, Jun 11, 2014 at 6:54 PM, Mark Brown <broonie@kernel.org> wrote:
>> > They're usually referred to as AKM when abbreviated and their web site
>> > is http://www.akm.com/ - don't know what the stock ticker symbol is.  In
>> > any case there's no real cost to adding both abbreviated and
>> > non-abbreviated forms if we want to transition.
>
>>     of: Add vendor prefix for Asahi Kasei Corp.
>
>>     Their stock ticker is 3407.T which wouldn't make a good DT vendor
>>     prefix. Use the company name initials instead.
>
> Sounds like akm, is a better bet then, especially as ak, has no real
> adoption.

Except for Автомат Калашникова...

> I think the bikeshed would be much better painted pink with yellow spots :)

Definitely.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [alsa-devel] "ak" vs "asahi-kasei"

[Stephen Warren]

[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]

On 06/11/2014 11:02 AM, Mark Brown wrote:
> On Wed, Jun 11, 2014 at 06:57:44PM +0200, Geert Uytterhoeven wrote:
>> On Wed, Jun 11, 2014 at 6:54 PM, Mark Brown <broonie@kernel.org> wrote:
> 
>>> They're usually referred to as AKM when abbreviated and their web site
>>> is http://www.akm.com/ - don't know what the stock ticker symbol is.  In
>>> any case there's no real cost to adding both abbreviated and
>>> non-abbreviated forms if we want to transition.
> 
>>     of: Add vendor prefix for Asahi Kasei Corp.
> 
>>     Their stock ticker is 3407.T which wouldn't make a good DT vendor
>>     prefix. Use the company name initials instead.
> 
> Sounds like akm, is a better bet then, especially as ak, has no real
> adoption.  
> 
> I think the bikeshed would be much better painted pink with yellow spots :)

Sorry to jump in on this late, but what on earth is wrong with "ak". It
went through the appropriate review process, and is already in use.
Admittedly only in a single ARM DT file, but it's still in use. We'll
have to allow the ak prefix forever given that DT is an ABI, so rather
than introducing more random variations, we should just stick with what
we have.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

Re: [alsa-devel] "ak" vs "asahi-kasei"

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

On Wed, Jun 11, 2014 at 12:51:41PM -0600, Stephen Warren wrote:
> On 06/11/2014 11:02 AM, Mark Brown wrote:

> > I think the bikeshed would be much better painted pink with yellow spots :)

> Sorry to jump in on this late, but what on earth is wrong with "ak". It
> went through the appropriate review process, and is already in use.
> Admittedly only in a single ARM DT file, but it's still in use. We'll
> have to allow the ak prefix forever given that DT is an ABI, so rather
> than introducing more random variations, we should just stick with what
> we have.

Well, the issue is that in reality the bulk of the drivers are using
asahi-kasei, we're going to have to churn at least something anyway.  We
seem to have one in tree user of ak in a DTS file and two DTSs using
asahi-kasei with seven drivers.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [alsa-devel] "ak" vs "asahi-kasei"

[Stephen Warren]

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

On 06/11/2014 01:04 PM, Mark Brown wrote:
> On Wed, Jun 11, 2014 at 12:51:41PM -0600, Stephen Warren wrote:
>> On 06/11/2014 11:02 AM, Mark Brown wrote:
> 
>>> I think the bikeshed would be much better painted pink with yellow spots :)
> 
>> Sorry to jump in on this late, but what on earth is wrong with "ak". It
>> went through the appropriate review process, and is already in use.
>> Admittedly only in a single ARM DT file, but it's still in use. We'll
>> have to allow the ak prefix forever given that DT is an ABI, so rather
>> than introducing more random variations, we should just stick with what
>> we have.
> 
> Well, the issue is that in reality the bulk of the drivers are using
> asahi-kasei, we're going to have to churn at least something anyway.  We
> seem to have one in tree user of ak in a DTS file and two DTSs using
> asahi-kasei with seven drivers.

As far as DTs go, there are only 2 users of asahi-kasei, and they were
both added well after the prefix was documented, so those seem like
plain old bugs.

But due to ABIness, perhaps we have to support both ak and asahi-kasei.
I don't think fixing this implies we should introduce a third option akm
though. No DT is using that today.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

[PATCH] of: Add vendor 2nd prefix for Asahi Kasei Corp

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has
"ak" prefix for Asahi Kasei Corp by
ae8c4209af2cec065fef15d200a42a04130799f7
(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process,
and is already in use.
But, almost all Asahi Kasei chip driver is
using "asahi-kasei" prefix today.

Due to ABIness, this patch adds
"asahi-kasei" to vendor-prefixes.txt.
checkpatch.pl will report WARNING without this patch.
(DT compatible string vendor "asahi-kasei" appears un-documented)

OTOH, Asahi Kasei is usually referred as "AKM",
but this patch doesn't care about it.
Because no DT is using it today.

Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index abc3080..7e4bb83 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -17,6 +17,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
-- 
1.7.9.5

Re: [PATCH] of: Add vendor 2nd prefix for Asahi Kasei Corp

[Simon Horman]

On Wed, Jun 11, 2014 at 05:53:02PM -0700, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Current vendor-prefixes.txt already has
> "ak" prefix for Asahi Kasei Corp by
> ae8c4209af2cec065fef15d200a42a04130799f7
> (of: Add vendor prefix for Asahi Kasei Corp.)
> 
> It went through the appropriate review process,
> and is already in use.
> But, almost all Asahi Kasei chip driver is
> using "asahi-kasei" prefix today.
> 
> Due to ABIness, this patch adds
> "asahi-kasei" to vendor-prefixes.txt.
> checkpatch.pl will report WARNING without this patch.
> (DT compatible string vendor "asahi-kasei" appears un-documented)
> 
> OTOH, Asahi Kasei is usually referred as "AKM",
> but this patch doesn't care about it.
> Because no DT is using it today.
> 
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Acked-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index abc3080..7e4bb83 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -17,6 +17,7 @@ amstaos	AMS-Taos Inc.
>  apm	Applied Micro Circuits Corporation (APM)
>  arm	ARM Ltd.
>  armadeus	ARMadeus Systems SARL
> +asahi-kasei	Asahi Kasei Corp.
>  atmel	Atmel Corporation
>  auo	AU Optronics Corporation
>  avago	Avago Technologies
> -- 
> 1.7.9.5
> 

Re: [alsa-devel] "ak" vs "asahi-kasei"

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

On Wed, Jun 11, 2014 at 01:16:23PM -0600, Stephen Warren wrote:

> As far as DTs go, there are only 2 users of asahi-kasei, and they were
> both added well after the prefix was documented, so those seem like
> plain old bugs.

> But due to ABIness, perhaps we have to support both ak and asahi-kasei.
> I don't think fixing this implies we should introduce a third option akm
> though. No DT is using that today.

See my prior comments about how fetching pink with yellow spots would be :)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] of: Add vendor 2nd prefix for Asahi Kasei Corp

[Stephen Warren]

On 06/11/2014 06:53 PM, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> 
> Current vendor-prefixes.txt already has
> "ak" prefix for Asahi Kasei Corp by
> ae8c4209af2cec065fef15d200a42a04130799f7
> (of: Add vendor prefix for Asahi Kasei Corp.)
> 
> It went through the appropriate review process,
> and is already in use.
> But, almost all Asahi Kasei chip driver is
> using "asahi-kasei" prefix today.

I'm fine with this patch, but just wanted to comment on this part of the
commit description:

What is in the drivers isn't relevant; that's not what drives the ABI.
The issue is that some *DTs* use ak and some use asahi-kasei, so both
those need to be supported.

That said, we should document which one of the two prefixes is
preferred, and use this for any new AK binding.

It would also be nice to ensure the preferred prefix is in all drivers'
of_match_tables, and remove the deprecated prefix from all drivers'
of_match_tables *except* where there's already a DT file that references
the deprecated vendor prefix.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has
"ak" prefix for Asahi Kasei Corp by
ae8c4209af2cec065fef15d200a42a04130799f7
(of: Add vendor prefix for Asahi Kasei Corp.)

But, almost all Asahi Kasei chip driver is
using "asahi-kasei" prefix today.

This patch adds "asahi-kasei" to vendor-prefixes.txt.
checkpatch.pl will report WARNING without this patch.
(DT compatible string vendor "asahi-kasei" appears un-documented)

OTOH, Asahi Kasei is usually referred to as "AKM",
but this patch doesn't care about it.
Because no DT is using it today.

Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index abc3080..7e4bb83 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -17,6 +17,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
-- 
1.7.9.5

Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp

[Mark Rutland]

On Thu, Sep 04, 2014 at 07:08:37AM +0100, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Current vendor-prefixes.txt already has
> "ak" prefix for Asahi Kasei Corp by
> ae8c4209af2cec065fef15d200a42a04130799f7
> (of: Add vendor prefix for Asahi Kasei Corp.)
> 
> But, almost all Asahi Kasei chip driver is
> using "asahi-kasei" prefix today.
> 
> This patch adds "asahi-kasei" to vendor-prefixes.txt.
> checkpatch.pl will report WARNING without this patch.
> (DT compatible string vendor "asahi-kasei" appears un-documented)

If we're adding a new string, we should figure out what's happening with
the old one. We want some consistency here.

>From a quick grep, it looks like the only use of "ak" is "ak,ak8975" in
arch/arm/boot/dts/tegra20-seaboard.dts. There are instances of
"asahi-kasei,ak8975" in other dts files.

Olof added "asahi-kasei,ak8975" to the ak8975 driver in February 2012
(see 54461c3067b2), and the "asahi-kasei" prefix is currently far more
common. This was only documented in May 2013 (see f4b7f751c6fd).

Stephen added the "ak" vendor-refix was added later in November 2012
(see ae8c4209af2c), and the only instance seems to work due to the i2c
subsystem doing something dehind the scenes with the compatible string.
So I think we made a mistake there.

Given all that, I think we should get rid of the "ak" prefix entirely,
fix up the seaboard dts, and leave the legacy matching for "ak,ak8975"
up to the i2c framework. However, that would imply deleting from
vendor-prefixes.txt (if we want people to be warned on use of "ak"), and
that's not a good precedent to set.

Thoughts?

Mark.

> OTOH, Asahi Kasei is usually referred to as "AKM",
> but this patch doesn't care about it.
> Because no DT is using it today.
> 
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
> Acked-by: Simon Horman <horms+renesas@verge.net.au>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index abc3080..7e4bb83 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -17,6 +17,7 @@ amstaos	AMS-Taos Inc.
>  apm	Applied Micro Circuits Corporation (APM)
>  arm	ARM Ltd.
>  armadeus	ARMadeus Systems SARL
> +asahi-kasei	Asahi Kasei Corp.
>  atmel	Atmel Corporation
>  auo	AU Optronics Corporation
>  avago	Avago Technologies
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp

[Geert Uytterhoeven]

Hi Mark,

On Mon, Sep 22, 2014 at 3:00 PM, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> Given all that, I think we should get rid of the "ak" prefix entirely,
> fix up the seaboard dts, and leave the legacy matching for "ak,ak8975"
> up to the i2c framework. However, that would imply deleting from
> vendor-prefixes.txt (if we want people to be warned on use of "ak"), and
> that's not a good precedent to set.

Instead of deleting, we can deprecate, like was done for powervr:

powervr PowerVR (deprecated, use img)

Still missing is an update for checkpatch to warn when a deprecated
vendor prefix is used.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp

[Mark Rutland]

On Mon, Sep 22, 2014 at 02:24:24PM +0100, Geert Uytterhoeven wrote:
> Hi Mark,

Hi Geert,

> On Mon, Sep 22, 2014 at 3:00 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> > Given all that, I think we should get rid of the "ak" prefix entirely,
> > fix up the seaboard dts, and leave the legacy matching for "ak,ak8975"
> > up to the i2c framework. However, that would imply deleting from
> > vendor-prefixes.txt (if we want people to be warned on use of "ak"), and
> > that's not a good precedent to set.
> 
> Instead of deleting, we can deprecate, like was done for powervr:
> 
> powervr PowerVR (deprecated, use img)

Ah. I tried to see if we had any deprecated bindings, but I somehow
failed to search correctly and missed powervr.

> Still missing is an update for checkpatch to warn when a deprecated
> vendor prefix is used.

Marking it deprecated and warning with checkpatch is certainly
preferable.

Mark.

Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp

[Kuninori Morimoto]

Hi Mark, Geert

Sorry for my super late response about this

> > > Given all that, I think we should get rid of the "ak" prefix entirely,
> > > fix up the seaboard dts, and leave the legacy matching for "ak,ak8975"
> > > up to the i2c framework. However, that would imply deleting from
> > > vendor-prefixes.txt (if we want people to be warned on use of "ak"), and
> > > that's not a good precedent to set.
> > 
> > Instead of deleting, we can deprecate, like was done for powervr:
> > 
> > powervr PowerVR (deprecated, use img)
> 
> Ah. I tried to see if we had any deprecated bindings, but I somehow
> failed to search correctly and missed powervr.
> 
> > Still missing is an update for checkpatch to warn when a deprecated
> > vendor prefix is used.
> 
> Marking it deprecated and warning with checkpatch is certainly
> preferable.

I guess removing "ak" line from vendor-prefixes.txt is very enough
for warn for a deprecated vendor prefix on checkpatch ?

  ...
- ak	Asahi Kasei Corp.
  ...
+ asahi-kasei	Asahi Kasei Corp.

Best regards
---
Kuninori Morimoto

Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp

[Joe Perches]

On Thu, 2014-11-13 at 02:18 +0000, Kuninori Morimoto wrote:
> > > Still missing is an update for checkpatch to warn when a deprecated
> > > vendor prefix is used.
> > 
> > Marking it deprecated and warning with checkpatch is certainly
> > preferable.
> 
> I guess removing "ak" line from vendor-prefixes.txt is very enough
> for warn for a deprecated vendor prefix on checkpatch ?

Huh?  No idea what you mean.
What are you suggesting about checkpatch?


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp

[Simon Horman]

On Wed, Nov 12, 2014 at 06:21:49PM -0800, Joe Perches wrote:
> On Thu, 2014-11-13 at 02:18 +0000, Kuninori Morimoto wrote:
> > > > Still missing is an update for checkpatch to warn when a deprecated
> > > > vendor prefix is used.
> > > 
> > > Marking it deprecated and warning with checkpatch is certainly
> > > preferable.
> > 
> > I guess removing "ak" line from vendor-prefixes.txt is very enough
> > for warn for a deprecated vendor prefix on checkpatch ?
> 
> Huh?  No idea what you mean.
> What are you suggesting about checkpatch?

Hi Joe,

I think that what Morimoto-san wanted to say was something like this:

  I guess that removing the "ak" line from vendor-prefixes.txt would
  be sufficient to cause checkpatch to generate a warning about
  using the deprecated "ak" vendor prefix. Is that a good approach?

Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp

[Kuninori Morimoto]

Hi Joe, Simon

> > > I guess removing "ak" line from vendor-prefixes.txt is very enough
> > > for warn for a deprecated vendor prefix on checkpatch ?
> > 
> > Huh?  No idea what you mean.
> > What are you suggesting about checkpatch?
> 
> Hi Joe,
> 
> I think that what Morimoto-san wanted to say was something like this:
> 
>   I guess that removing the "ak" line from vendor-prefixes.txt would
>   be sufficient to cause checkpatch to generate a warning about
>   using the deprecated "ak" vendor prefix. Is that a good approach?

Yes, this is.
Thank you Simon, Sorry Joe.

Re: [PATCH][resend] of: Add vendor 2nd prefix for Asahi Kasei Corp

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

On Thu, Nov 13, 2014 at 03:33:38AM +0000, Kuninori Morimoto wrote:

> > I think that what Morimoto-san wanted to say was something like this:

> >   I guess that removing the "ak" line from vendor-prefixes.txt would
> >   be sufficient to cause checkpatch to generate a warning about
> >   using the deprecated "ak" vendor prefix. Is that a good approach?

> Yes, this is.
> Thank you Simon, Sorry Joe.

It'd be a bit nicer to be able to leave it there with a note saying it
was legacy (if only so people don't try to add it back) but I don't mind
too much.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[PATCH v3] of: replace Asahi Kasei Corp venter prefix

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

Current vendor-prefixes.txt already has
"ak" prefix for Asahi Kasei Corp by
ae8c4209af2cec065fef15d200a42a04130799f7
(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process.
But, almost all Asahi Kasei chip drivers are
using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is
using "ak,ak8975", but there are instances of
"asahi-kasei,ak8975" in other dts files.
And drivers/iio/magnetometer/ak8975.c
doesn't support "ak,ak8975")
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING
if it is using "asahi-kasei" prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch
is certainly preferable.
So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM",
but this patch doesn't care about it.
Because no DT is using that today.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] of: replace Asahi Kasei Corp venter prefix

[Alexandre Courbot]

On 11/14/2014 10:43 AM, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
>
> Current vendor-prefixes.txt already has
> "ak" prefix for Asahi Kasei Corp by
> ae8c4209af2cec065fef15d200a42a04130799f7
> (of: Add vendor prefix for Asahi Kasei Corp.)
>
> It went through the appropriate review process.
> But, almost all Asahi Kasei chip drivers are
> using "asahi-kasei" prefix today.
> (arch/arm/boot/dts/tegra20-seaboard.dts only is
> using "ak,ak8975", but there are instances of
> "asahi-kasei,ak8975" in other dts files.
> And drivers/iio/magnetometer/ak8975.c
> doesn't support "ak,ak8975")
> So, we made a mistake there.
>
> In addition, checkpatch.pl reports WARNING
> if it is using "asahi-kasei" prerfix in DT file.
> (DT compatible string vendor "asahi-kasei" appears un-documented)
>
> Marking it deprecated and warning with checkpatch
> is certainly preferable.
> So, this patch replace "ak" to "asahi-kasei" in
> vendor-prefixes.txt. (and fixup tegra20-seaboard)
>
> OTOH, Asahi Kasei is usually referred to as "AKM",
> but this patch doesn't care about it.
> Because no DT is using that today.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> ---
>   .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
>   arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 723999d..ddcb4cd 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -9,7 +9,6 @@ ad	Avionic Design GmbH
>   adapteva	Adapteva, Inc.
>   adi	Analog Devices, Inc.
>   aeroflexgaisler	Aeroflex Gaisler AB
> -ak	Asahi Kasei Corp.
>   allwinner	Allwinner Technology Co., Ltd.
>   altr	Altera Corp.
>   amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
> @@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
>   apm	Applied Micro Circuits Corporation (APM)
>   arm	ARM Ltd.
>   armadeus	ARMadeus Systems SARL
> +asahi-kasei	Asahi Kasei Corp.
>   atmel	Atmel Corporation
>   auo	AU Optronics Corporation
>   avago	Avago Technologies
> diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
> index a1d4bf9..7f5cf80 100644
> --- a/arch/arm/boot/dts/tegra20-seaboard.dts
> +++ b/arch/arm/boot/dts/tegra20-seaboard.dts
> @@ -405,7 +405,7 @@
>   		clock-frequency = <400000>;
>
>   		magnetometer@c {
> -			compatible = "ak,ak8975";
> +			compatible = "asahi-kasei,ak8975";

Mmm. So does this mean this device was never probed because the driver 
did not recognize its compatible property? I cannot find "ak,ak8975" 
anywhere else in the kernel.

If so,

Acked-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Re: [PATCH v3] of: replace Asahi Kasei Corp venter prefix

[Arnd Bergmann]

On Friday 14 November 2014 17:38:58 Alexandre Courbot wrote:
> > diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
> > index a1d4bf9..7f5cf80 100644
> > --- a/arch/arm/boot/dts/tegra20-seaboard.dts
> > +++ b/arch/arm/boot/dts/tegra20-seaboard.dts
> > @@ -405,7 +405,7 @@
> >               clock-frequency = <400000>;
> >
> >               magnetometer@c {
> > -                     compatible = "ak,ak8975";
> > +                     compatible = "asahi-kasei,ak8975";
> 
> Mmm. So does this mean this device was never probed because the driver 
> did not recognize its compatible property? I cannot find "ak,ak8975" 
> anywhere else in the kernel.
> 

No, the i2c bus behaves in a special way by matching the "ak8975"
i2c driver name with any "*,ak8975" DT compatible string. Both
of the above will work with existing kernels.

	Arnd

Re: [PATCH v3] of: replace Asahi Kasei Corp venter prefix

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1562 bytes --]

On Fri, Nov 14, 2014 at 05:38:58PM +0900, Alexandre Courbot wrote:
> On 11/14/2014 10:43 AM, Kuninori Morimoto wrote:
[...]
> >diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
> >index a1d4bf9..7f5cf80 100644
> >--- a/arch/arm/boot/dts/tegra20-seaboard.dts
> >+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
> >@@ -405,7 +405,7 @@
> >  		clock-frequency = <400000>;
> >
> >  		magnetometer@c {
> >-			compatible = "ak,ak8975";
> >+			compatible = "asahi-kasei,ak8975";
> 
> Mmm. So does this mean this device was never probed because the driver did
> not recognize its compatible property?

I2C (like SPI) has a fallback in case the OF table yields no match. The
of_modalias_node() that it uses extracts the module name from the device
tree node's compatible string by skipping the vendor prefix. The
resulting string is then set as the I2C client's name and causes the I2C
standard ID matching to succeed (see of_i2c_register_devices() for how
this is done in detail).

> I cannot find "ak,ak8975" anywhere else in the kernel.
> 
> If so,
> 
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>

Technically this is breaking backwards-compatibility from a DT
perspective, but I think it's safe to do because the Linux kernel has a
way of dealing with this and other operating systems should be able to
deal with this in a similar way (or even easier by letting the driver
match on the ak prefix as well for this particular chip).

So:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [alsa-devel] [PATCH v3] of: replace Asahi Kasei Corp venter prefix

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

On Fri, Nov 14, 2014 at 01:43:03AM +0000, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> 
> Current vendor-prefixes.txt already has
> "ak" prefix for Asahi Kasei Corp by
> ae8c4209af2cec065fef15d200a42a04130799f7

It's usually enough to show the first 12 (or so) characters of the SHA1
here. git will show you the right one if you do something like:

	git log --abbrev=12 --abbrev-commit

It's probably useful to "git config core.abbrev 12" for Linux kernel
repositories.

Other than that it seems like you're being overly careful about not
exceeding 72 characters. Your lines seem to wrap at around less than
50 columns. However, making lines too short results in equally hard to
read commit messages, so please try to shoot for 72 columns for maximum
readability.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

[PATCH v4] of: replace Asahi Kasei Corp venter prefix

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process. But, almost all
Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
 but there are instances of "asahi-kasei,ak8975" in other dts files.
 And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975")
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch is certainly
preferable. So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
doesn't care about it. Because no DT is using that today.

Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Acked-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
v3 -> v4

 - git-comment uses 72 char in 1 line
 - added Thierry/Alexandre's Acked-by

 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5

Re: [PATCH v4] of: replace Asahi Kasei Corp venter prefix

[Sergei Shtylyov]

Hello.

On 11/17/2014 3:51 AM, Kuninori Morimoto wrote:

> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

    s/venter/vendor/ in the subject. Sorry for a late comment.

> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
> by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

> It went through the appropriate review process. But, almost all
> Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
> (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
>   but there are instances of "asahi-kasei,ak8975" in other dts files.
>   And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975")
> So, we made a mistake there.

> In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
> prerfix in DT file.
> (DT compatible string vendor "asahi-kasei" appears un-documented)

> Marking it deprecated and warning with checkpatch is certainly
> preferable. So, this patch replace "ak" to "asahi-kasei" in
> vendor-prefixes.txt. (and fixup tegra20-seaboard)

> OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
> doesn't care about it. Because no DT is using that today.

> Acked-by: Thierry Reding <treding@nvidia.com>
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

    One normally places ACKs after his own sign-off.

WBR, Sergei

[PATCH v5] of: replace Asahi Kasei Corp vendor prefix

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process. But, almost all
Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
 but there are instances of "asahi-kasei,ak8975" in other dts files.
 And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch is certainly
preferable. So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
doesn't care about it. Because no DT is using that today.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
---
v4 -> v5

 - venter -> vendor on Subject
 - fixup Acked-by ordering

 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5

[PATCH v5][resend] of: replace Asahi Kasei Corp venter prefix

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process. But, almost all
Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
 but there are instances of "asahi-kasei,ak8975" in other dts files.
 And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch is certainly
preferable. So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
doesn't care about it. Because no DT is using that today.

Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Acked-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5

Re: [PATCH v5][resend] of: replace Asahi Kasei Corp venter prefix

[Sergei Shtylyov]

Hello.

On 11/28/2014 3:22 AM, Kuninori Morimoto wrote:

> From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
> by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

> It went through the appropriate review process. But, almost all
> Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
> (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
>   but there are instances of "asahi-kasei,ak8975" in other dts files.
>   And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
> So, we made a mistake there.

> In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
> prerfix in DT file.
> (DT compatible string vendor "asahi-kasei" appears un-documented)

> Marking it deprecated and warning with checkpatch is certainly
> preferable. So, this patch replace "ak" to "asahi-kasei" in
> vendor-prefixes.txt. (and fixup tegra20-seaboard)

> OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
> doesn't care about it. Because no DT is using that today.

> Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Acked-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

    It's "venter" ISO "vendor" again in the subject. And you already fixed 
that in the previous posting... :-)

WBR, Sergei

[PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process. But, almost all
Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
 but there are instances of "asahi-kasei,ak8975" in other dts files.
 And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch is certainly
preferable. So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
doesn't care about it. Because no DT is using that today.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Acked-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
v4 -> v5

 - venter -> vendor on Subject
 - fixup Acked-by ordering

 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v5][resend v2] of: replace Asahi Kasei Corp vendor prefix

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)

It went through the appropriate review process. But, almost all
Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
(arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
 but there are instances of "asahi-kasei,ak8975" in other dts files.
 And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
So, we made a mistake there.

In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
prerfix in DT file.
(DT compatible string vendor "asahi-kasei" appears un-documented)

Marking it deprecated and warning with checkpatch is certainly
preferable. So, this patch replace "ak" to "asahi-kasei" in
vendor-prefixes.txt. (and fixup tegra20-seaboard)

OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
doesn't care about it. Because no DT is using that today.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Acked-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
Rob, Mark

There is no response about this patch.
Mark, is it possible to care about this patch ?
It has relationship to ASoC.

 .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..ddcb4cd 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -9,7 +9,6 @@ ad	Avionic Design GmbH
 adapteva	Adapteva, Inc.
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
-ak	Asahi Kasei Corp.
 allwinner	Allwinner Technology Co., Ltd.
 altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
@@ -20,6 +19,7 @@ amstaos	AMS-Taos Inc.
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
+asahi-kasei	Asahi Kasei Corp.
 atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
index a1d4bf9..7f5cf80 100644
--- a/arch/arm/boot/dts/tegra20-seaboard.dts
+++ b/arch/arm/boot/dts/tegra20-seaboard.dts
@@ -405,7 +405,7 @@
 		clock-frequency = <400000>;
 
 		magnetometer@c {
-			compatible = "ak,ak8975";
+			compatible = "asahi-kasei,ak8975";
 			reg = <0xc>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5

Re: [PATCH v5][resend] of: replace Asahi Kasei Corp vendor prefix

[Rob Herring]

On Mon, Dec 1, 2014 at 10:57 PM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp
> by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.)
>
> It went through the appropriate review process. But, almost all
> Asahi Kasei chip drivers are using "asahi-kasei" prefix today.
> (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975",
>  but there are instances of "asahi-kasei,ak8975" in other dts files.
>  And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix)
> So, we made a mistake there.
>
> In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei"
> prerfix in DT file.
> (DT compatible string vendor "asahi-kasei" appears un-documented)
>
> Marking it deprecated and warning with checkpatch is certainly
> preferable. So, this patch replace "ak" to "asahi-kasei" in
> vendor-prefixes.txt. (and fixup tegra20-seaboard)
>
> OTOH, Asahi Kasei is usually referred to as "AKM", but this patch
> doesn't care about it. Because no DT is using that today.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>

Applied for 3.20. Thanks.

> ---
> v4 -> v5
>
>  - venter -> vendor on Subject
>  - fixup Acked-by ordering
>
>  .../devicetree/bindings/vendor-prefixes.txt        |    2 +-
>  arch/arm/boot/dts/tegra20-seaboard.dts             |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 723999d..ddcb4cd 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -9,7 +9,6 @@ ad      Avionic Design GmbH
>  adapteva       Adapteva, Inc.
>  adi    Analog Devices, Inc.
>  aeroflexgaisler        Aeroflex Gaisler AB
> -ak     Asahi Kasei Corp.
>  allwinner      Allwinner Technology Co., Ltd.
>  altr   Altera Corp.
>  amcc   Applied Micro Circuits Corporation (APM, formally AMCC)
> @@ -20,6 +19,7 @@ amstaos       AMS-Taos Inc.
>  apm    Applied Micro Circuits Corporation (APM)
>  arm    ARM Ltd.
>  armadeus       ARMadeus Systems SARL
> +asahi-kasei    Asahi Kasei Corp.
>  atmel  Atmel Corporation
>  auo    AU Optronics Corporation
>  avago  Avago Technologies
> diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
> index a1d4bf9..7f5cf80 100644
> --- a/arch/arm/boot/dts/tegra20-seaboard.dts
> +++ b/arch/arm/boot/dts/tegra20-seaboard.dts
> @@ -405,7 +405,7 @@
>                 clock-frequency = <400000>;
>
>                 magnetometer@c {
> -                       compatible = "ak,ak8975";
> +                       compatible = "asahi-kasei,ak8975";
>                         reg = <0xc>;
>                         interrupt-parent = <&gpio>;
>                         interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;
> --
> 1.7.9.5
>