From: Mike Turquette <mturquette@linaro.org>
To: Alexandru Stan <amstan@chromium.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
addy ke <addy.ke@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
linux-kernel@vger.kernel.org,
Kever Yang <kever.yang@rock-chips.com>,
Doug Anderson <dianders@chromium.org>,
linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
galak@codeaurora.org, Sonny Rao <sonnyrao@chromium.org>,
linux-arm-kernel@lists.infradead.org, mark.yao@rock-chips.com
Subject: Re: [PATCH v2 1/2] clk: rockchip: add bindings for the mmc clock phases
Date: Mon, 17 Nov 2014 13:16:06 -0800 [thread overview]
Message-ID: <20141117211606.25314.43161@quantum> (raw)
In-Reply-To: <CAHNYxRwGWqbznVybmE+tpyghEoQwVFK_V2ubFRKXasvsPS+R7Q@mail.gmail.com>
Quoting Alexandru Stan (2014-11-17 11:50:51)
> Sorry for my previous mail, I sent it as HTML and also top posted.
> Here it goes again:
>
> On Mon, Nov 17, 2014 at 11:39 AM, Mike Turquette <mturquette@linaro.org> wrote:
> > It looks like you are adding new clocks to handle the phase requirement.
> > Is that the right thing to do? Don't these clks already exist (e.g.
> > SCLK_SDMMC)?
> I actually need to control 2 phases, one of them is used when
> outputting data, the other when sampling. Sunxi does something
> similar: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/273273.html
>
> Another reason it wouldn't work is because the upstream clock(eg
> SCLK_SDMMC) is twice as fast as the real clock(see RK3288_CLKGEN_DIV
> in drivers/mmc/host/dw_mmc-rockchip.c), since that clock goes to a /2
> divider to be able to do the 90 degree clock phases.
Thanks for the explanation.
Regards,
Mike
>
> Alexandru Stan
next prev parent reply other threads:[~2014-11-17 21:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 0:00 [PATCH v2 0/2] Add support for the rockchip mmc clock phases using the framework Alexandru M Stan
2014-11-15 0:00 ` [PATCH v2 1/2] clk: rockchip: add bindings for the mmc clock phases Alexandru M Stan
[not found] ` <1416009604-31545-2-git-send-email-amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-11-17 19:39 ` Mike Turquette
2014-11-17 19:47 ` Alexandru Stan
2014-11-17 19:50 ` Alexandru Stan
2014-11-17 21:16 ` Mike Turquette [this message]
2014-11-15 0:00 ` [PATCH v2 2/2] clk: rockchip: Add support for the mmc clock phases using the framework Alexandru M Stan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117211606.25314.43161@quantum \
--to=mturquette@linaro.org \
--cc=addy.ke@rock-chips.com \
--cc=amstan@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mark.yao@rock-chips.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sonnyrao@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).