From: Lee Jones <lee.jones@linaro.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
broonie@kernel.org, mturquette@linaro.org, a.zummo@towertech.it,
lgirdwood@gmail.com, sameo@linux.intel.com,
geunsik.lim@samsung.com, inki.dae@samsung.com,
kyungmin.park@samsung.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] rtc: s5m: Add the support for S2MPS13 RTC
Date: Tue, 18 Nov 2014 08:25:27 +0000 [thread overview]
Message-ID: <20141118082527.GV24004@x1> (raw)
In-Reply-To: <546A98EC.8090009@samsung.com>
On Tue, 18 Nov 2014, Chanwoo Choi wrote:
> Dear Sangbeom,
>
> On 11/18/2014 09:38 AM, Sangbeom Kim wrote:
> > Hi,
> > On Monday, November 17, 2014 9:43 AM, Chanwoo Choi wrote:
> >> This patch adds only the compatible string for S2MPS13 clock which is identical
> >> with S2MPS14 clock driver.
> >
> > What's the relation of S2MPS14 RTC and clock driver?
>
> I checked the difference between S2MPS13 and S2MPS14.
> But, all register (RTC) of both PMICs was the same completely.
> So, I just add S2MPS13 type to use existing S2MPS14 RTC feature for S2MPS13 RTC.
Okay, so it looks like this requires another submission. Please add
the fixup I requested in the first patch.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-11-18 8:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 0:42 [PATCH 0/5] mfd: sec-core: Add support S2MPS13 PMIC device Chanwoo Choi
2014-11-17 0:42 ` [PATCH 1/5] mfd: sec-core: Add support for S2MPS13 device Chanwoo Choi
[not found] ` <1416184980-532-2-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-18 0:26 ` Sangbeom Kim
2014-11-18 8:22 ` Lee Jones
2014-11-18 8:33 ` Chanwoo Choi
2014-11-17 0:42 ` [PATCH 2/5] regulator: s2mps11: Add support S2MPS13 regulator device Chanwoo Choi
[not found] ` <1416184980-532-3-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-17 10:12 ` Krzysztof Kozłowski
[not found] ` <5469CA11.3000409-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-18 0:57 ` Chanwoo Choi
2014-11-17 23:48 ` Mark Brown
2014-11-18 0:28 ` Sangbeom Kim
2014-11-18 8:17 ` Lee Jones
2014-11-18 8:41 ` Chanwoo Choi
2014-11-17 0:42 ` [PATCH 3/5] clk: s2mps11: Add the support for S2MPS13 PMIC clock Chanwoo Choi
2014-11-17 10:16 ` Krzysztof Kozłowski
[not found] ` <5469CAF9.6020700-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-18 1:06 ` Chanwoo Choi
2014-11-17 0:42 ` [PATCH 4/5] rtc: s5m: Add the support for S2MPS13 RTC Chanwoo Choi
[not found] ` <1416184980-532-5-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-17 10:19 ` Krzysztof Kozłowski
2014-11-18 1:14 ` Chanwoo Choi
[not found] ` <546A9D7D.7040207-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-18 10:01 ` Krzysztof Kozlowski
2014-11-18 0:38 ` Sangbeom Kim
2014-11-18 0:55 ` Chanwoo Choi
2014-11-18 8:25 ` Lee Jones [this message]
2014-11-18 8:53 ` Chanwoo Choi
2014-11-17 0:43 ` [PATCH 5/5] mfd: s2mps11: Add binding documentation for Samsung S2MPS13 PMIC Chanwoo Choi
[not found] ` <1416184980-532-6-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-11-17 10:20 ` Krzysztof Kozłowski
2014-11-18 0:40 ` Sangbeom Kim
2014-11-18 8:19 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118082527.GV24004@x1 \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=geunsik.lim@samsung.com \
--cc=inki.dae@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).