devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: Flora Fu <flora.fu@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Grant Likely <grant.likely@linaro.org>,
	"Joe.C" <yingjoe.chen@mediatek.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Vladimir Murzin <vladimir.murzin@arm.com>,
	Ashwin Chaugule <ashwin.chaugule@linaro.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	srv_heupstream@mediatek.com, Sascha Hauer <kernel@pengutronix.de>,
	Eddie Huang <eddie.huang@mediatek.com>,
	Dongdong Cheng <dongdong.cheng@mediatek.com>
Subject: Re: [PATCH 2/7] mfd: MT6397: Add regmap for MT8135 and MT6397 SoC
Date: Tue, 18 Nov 2014 14:46:18 +0100	[thread overview]
Message-ID: <20141118134618.GF30369@pengutronix.de> (raw)
In-Reply-To: <20141118114645.GX24004@x1>

On Tue, Nov 18, 2014 at 11:46:45AM +0000, Lee Jones wrote:
> On Mon, 17 Nov 2014, Flora Fu wrote:
> 
> > Add PMIC wrapper of MT8135 to access MFD MT6397.
> > This is regmap of MT6397 MFD.
> > 
> > Signed-off-by: Flora Fu <flora.fu@mediatek.com>
> > ---
> >  drivers/mfd/Kconfig            |   8 +
> >  drivers/mfd/Makefile           |   1 +
> >  drivers/mfd/mt8135-pmic-wrap.c | 847 +++++++++++++++++++++++++++++++++++++++++
> 
> All of the PMIC functionality needs removing from MFD and placed
> somewhere else.  I suggest either drivers/power or drivers/regulator.

This is no PMIC functionality. The MT8135 has a unit which is is used to
access the PMIC (which is not only a PMIC, but also Touchscreen
interface and other stuff). This unit is called pmic-wrapper in the
docs. See the introductory mail for a nice picture.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2014-11-18 13:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-17  7:40 Add Support for MediaTek PMIC MT6397 MFD Core and Regulator Flora Fu
2014-11-17  7:40 ` [PATCH 1/7] mfd: MT6397: Add support for PMIC MT6397 MFD Flora Fu
2014-11-18 11:59   ` Lee Jones
2014-11-17  7:40 ` [PATCH 2/7] mfd: MT6397: Add regmap for MT8135 and MT6397 SoC Flora Fu
2014-11-18 11:46   ` Lee Jones
2014-11-18 13:46     ` Sascha Hauer [this message]
     [not found]       ` <20141118134618.GF30369-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-11-19 17:04         ` Lee Jones
2014-11-20  9:19           ` Sascha Hauer
     [not found]             ` <20141120091943.GJ30369-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-11-20 10:38               ` Lee Jones
2014-11-17  7:40 ` [PATCH 3/7] regulator: MT6397: Add support for MT6397 regulator Flora Fu
     [not found]   ` <1416210027-5562-4-git-send-email-flora.fu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2014-11-17 23:40     ` Mark Brown
2014-11-21  7:09       ` Flora Fu
2014-11-21 10:16         ` Mark Brown
2014-11-17  7:40 ` [PATCH 4/7] dt-bindings: Add document for MT6397 MFD Flora Fu
     [not found]   ` <1416210027-5562-5-git-send-email-flora.fu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2014-11-17 23:31     ` Mark Brown
2014-11-17  7:40 ` [PATCH 5/7] dt-bindings: Add document for MT6397 regulator Flora Fu
2014-11-17  7:40 ` [PATCH 6/7] ARM: dts: mt8135: Add support for PMIC MT6397 MFD Flora Fu
2014-11-17  7:40 ` [PATCH 7/7] ARM: dts: mt8135: Add support for MT6397 regulator Flora Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141118134618.GF30369@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=ashwin.chaugule@linaro.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dongdong.cheng@mediatek.com \
    --cc=eddie.huang@mediatek.com \
    --cc=flora.fu@mediatek.com \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kernel@pengutronix.de \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=vladimir.murzin@arm.com \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).