From: Shawn Guo <shawn.guo@linaro.org>
To: Robin Gong <b38343@freescale.com>
Cc: kernel@pengutronix.de, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, linux@arm.linux.org.uk, sre@kernel.org,
dbaryshkov@gmail.com, dwmw2@infradead.org,
grant.likely@linaro.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, smoch@web.de
Subject: Re: [PATCH 1/3] ARM: dts: imx6: add pm_power_off support for i.mx6 chips
Date: Wed, 19 Nov 2014 11:18:24 +0800 [thread overview]
Message-ID: <20141119031823.GC27759@dragon> (raw)
In-Reply-To: <1415780439-29728-2-git-send-email-b38343@freescale.com>
On Wed, Nov 12, 2014 at 04:20:37PM +0800, Robin Gong wrote:
> All chips of i.mx6 can be powered off by programming SNVS.
> For example :
> On i.mx6q-sabresd board, PMIC_ON_REQ connect with external
> pmic ON/OFF pin, that will cause the whole PMIC powered off
> except VSNVS. And system can restart once PMIC_ON_REQ goes
> high by push POWRER key.
>
> Signed-off-by: Robin Gong <b38343@freescale.com>
> ---
> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 4 ++++
> arch/arm/boot/dts/imx6qdl.dtsi | 6 ++++++
> arch/arm/boot/dts/imx6sl-evk.dts | 4 ++++
> arch/arm/boot/dts/imx6sl.dtsi | 6 ++++++
> arch/arm/boot/dts/imx6sx-sdb.dts | 4 ++++
> arch/arm/boot/dts/imx6sx.dtsi | 6 ++++++
> 6 files changed, 30 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index 07fb302..ba12cc6 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -531,6 +531,10 @@
> status = "okay";
> };
>
> +&snvs-poweroff {
> + status = "okay";
> +};
> +
> &ssi2 {
> status = "okay";
> };
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index c701af9..3a032d1 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -645,6 +645,12 @@
> interrupts = <0 19 IRQ_TYPE_LEVEL_HIGH>,
> <0 20 IRQ_TYPE_LEVEL_HIGH>;
> };
> +
> + snvs-poweroff: snvs-poweroff@38 {
I'm not sure if it's because my DTC version is too low or you didn't
test, the DTC reports error in label name 'snvs-poweroff'. IIRC, hyphen
'-' cannot be used in label name, but underscore '_' can.
Shawn
> + compatible = "fsl,sec-v4.0-poweroff";
> + reg = <0x38 0x4>;
> + status = "disabled";
> + };
> };
>
> epit1: epit@020d0000 { /* EPIT1 */
> diff --git a/arch/arm/boot/dts/imx6sl-evk.dts b/arch/arm/boot/dts/imx6sl-evk.dts
> index 3f9e041..dab588f 100644
> --- a/arch/arm/boot/dts/imx6sl-evk.dts
> +++ b/arch/arm/boot/dts/imx6sl-evk.dts
> @@ -488,6 +488,10 @@
> status = "okay";
> };
>
> +&snvs-poweroff {
> + status = "okay";
> +};
> +
> &ssi2 {
> status = "okay";
> };
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 505da9e..5e5ed07 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -565,6 +565,12 @@
> interrupts = <0 19 IRQ_TYPE_LEVEL_HIGH>,
> <0 20 IRQ_TYPE_LEVEL_HIGH>;
> };
> +
> + snvs-poweroff: snvs-poweroff@38 {
> + compatible = "fsl,sec-v4.0-poweroff";
> + reg = <0x38 0x4>;
> + status = "disabled";
> + };
> };
>
> epit1: epit@020d0000 {
> diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts b/arch/arm/boot/dts/imx6sx-sdb.dts
> index a3980d9..78dc031 100644
> --- a/arch/arm/boot/dts/imx6sx-sdb.dts
> +++ b/arch/arm/boot/dts/imx6sx-sdb.dts
> @@ -251,6 +251,10 @@
> };
> };
>
> +&snvs-poweroff {
> + status = "okay";
> +};
> +
> &ssi2 {
> status = "okay";
> };
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index f4b9da6..652be9f 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -668,6 +668,12 @@
> reg = <0x34 0x58>;
> interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
> };
> +
> + snvs-poweroff: snvs-poweroff@38 {
> + compatible = "fsl,sec-v4.0-poweroff";
> + reg = <0x38 0x4>;
> + status = "disabled";
> + };
> };
>
> epit1: epit@020d0000 {
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2014-11-19 3:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 8:20 [PATCH v4 0/3] add power off driver for i.mx6 Robin Gong
2014-11-12 8:20 ` [PATCH 1/3] ARM: dts: imx6: add pm_power_off support for i.mx6 chips Robin Gong
2014-11-19 3:18 ` Shawn Guo [this message]
2014-11-19 5:26 ` Soeren Moch
2014-11-19 5:50 ` Robin Gong
2014-11-19 6:04 ` Shawn Guo
2014-11-21 9:00 ` Robin Gong
2014-11-12 8:20 ` [PATCH 2/3] power: reset: imx-snvs-poweroff: add power off driver for i.mx6 Robin Gong
2014-11-12 16:59 ` Sebastian Reichel
2014-11-12 8:20 ` [PATCH 3/3] ARM: configs: imx_v6_v7_defconfig: add power off driver Robin Gong
2014-11-12 10:56 ` [PATCH v4 0/3] add power off driver for i.mx6 Shawn Guo
2014-11-12 11:26 ` Arnd Bergmann
2014-11-13 2:10 ` Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119031823.GC27759@dragon \
--to=shawn.guo@linaro.org \
--cc=b38343@freescale.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=smoch@web.de \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).