From: Robin Gong <b38343@freescale.com>
To: Soeren Moch <smoch@web.de>
Cc: Shawn Guo <shawn.guo@linaro.org>,
kernel@pengutronix.de, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, linux@arm.linux.org.uk, sre@kernel.org,
dbaryshkov@gmail.com, grant.likely@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: imx6: add pm_power_off support for i.mx6 chips
Date: Wed, 19 Nov 2014 13:50:07 +0800 [thread overview]
Message-ID: <20141119055006.GA27258@Robin-OptiPlex-780> (raw)
In-Reply-To: <546C2A13.3010307@web.de>
Sorry, the patch resent wrongly...
Hi Shawn, Can you apply the first v4 patches on Sep 26, or I resend it again?
On Wed, Nov 19, 2014 at 06:26:43AM +0100, Soeren Moch wrote:
>
> On 19.11.2014 04:18, Shawn Guo wrote:
> > On Wed, Nov 12, 2014 at 04:20:37PM +0800, Robin Gong wrote:
> >> All chips of i.mx6 can be powered off by programming SNVS.
> >> For example :
> >> On i.mx6q-sabresd board, PMIC_ON_REQ connect with external
> >> pmic ON/OFF pin, that will cause the whole PMIC powered off
> >> except VSNVS. And system can restart once PMIC_ON_REQ goes
> >> high by push POWRER key.
> >>
> >> Signed-off-by: Robin Gong <b38343@freescale.com>
> >> ---
> >> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 4 ++++
> >> arch/arm/boot/dts/imx6qdl.dtsi | 6 ++++++
> >> arch/arm/boot/dts/imx6sl-evk.dts | 4 ++++
> >> arch/arm/boot/dts/imx6sl.dtsi | 6 ++++++
> >> arch/arm/boot/dts/imx6sx-sdb.dts | 4 ++++
> >> arch/arm/boot/dts/imx6sx.dtsi | 6 ++++++
> >> 6 files changed, 30 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> >> index 07fb302..ba12cc6 100644
> >> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> >> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> >> @@ -531,6 +531,10 @@
> >> status = "okay";
> >> };
> >>
> >> +&snvs-poweroff {
> >> + status = "okay";
> >> +};"
> >> +
> >> &ssi2 {
> >> status = "okay";
> >> };
> >> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> >> index c701af9..3a032d1 100644
> >> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> >> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> >> @@ -645,6 +645,12 @@
> >> interrupts = <0 19 IRQ_TYPE_LEVEL_HIGH>,
> >> <0 20 IRQ_TYPE_LEVEL_HIGH>;
> >> };
> >> +
> >> + snvs-poweroff: snvs-poweroff@38 {
> >
> > I'm not sure if it's because my DTC version is too low or you didn't
> > test, the DTC reports error in label name 'snvs-poweroff'. IIRC, hyphen
> > '-' cannot be used in label name, but underscore '_' can.
> >
> > Shawn
>
> In the patch series "[PATCH v4 0/3] add power off driver for i.mx6" from
> Sep 26 (what I have tested) snvs_poweroff was used. This worked as expected.
>
> So this series "[PATCH v4 0/3] add power off driver for i.mx6" (sent on
> Nov 12) apparently contains old patches and is not simply resent as
> stated in the cover letter.
>
> Soeren
next prev parent reply other threads:[~2014-11-19 5:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 8:20 [PATCH v4 0/3] add power off driver for i.mx6 Robin Gong
2014-11-12 8:20 ` [PATCH 1/3] ARM: dts: imx6: add pm_power_off support for i.mx6 chips Robin Gong
2014-11-19 3:18 ` Shawn Guo
2014-11-19 5:26 ` Soeren Moch
2014-11-19 5:50 ` Robin Gong [this message]
2014-11-19 6:04 ` Shawn Guo
2014-11-21 9:00 ` Robin Gong
2014-11-12 8:20 ` [PATCH 2/3] power: reset: imx-snvs-poweroff: add power off driver for i.mx6 Robin Gong
2014-11-12 16:59 ` Sebastian Reichel
2014-11-12 8:20 ` [PATCH 3/3] ARM: configs: imx_v6_v7_defconfig: add power off driver Robin Gong
2014-11-12 10:56 ` [PATCH v4 0/3] add power off driver for i.mx6 Shawn Guo
2014-11-12 11:26 ` Arnd Bergmann
2014-11-13 2:10 ` Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119055006.GA27258@Robin-OptiPlex-780 \
--to=b38343@freescale.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=smoch@web.de \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).