devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
	Gregory Clement
	<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Sebastian Hesselbarth
	<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Ben Peddell <klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCHv4 04/10] arm: mvebu: move Armada 370/XP pinctrl node definition armada-370-xp.dtsi
Date: Wed, 19 Nov 2014 09:03:23 +0100	[thread overview]
Message-ID: <20141119080323.GS27002@pengutronix.de> (raw)
In-Reply-To: <f4b15c942f543b0c0becd7c82bce07e9e0b603cf.1416351426.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>

Hello Arnaud,

On Wed, Nov 19, 2014 at 12:02:11AM +0100, Arnaud Ebalard wrote:
> +
> +	sdio_pins: sdio-pins {
> +		marvell,pins = "mpp30", "mpp31", "mpp32",
> +			       "mpp33", "mpp34", "mpp35";
> +		marvell,function = "sd0";
> +	};
> +};
> \ No newline at end of file
IMHO you should add this \n at the end.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-11-19  8:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18 23:01 [PATCHv4 00/10] arm: mvebu: add Synology DS213j and DS414 .dts files Arnaud Ebalard
     [not found] ` <cover.1416351425.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
2014-11-18 23:01   ` [PATCHv4 01/10] arm: mvebu: fix vendor prefix typo in kirkwood-synology.dtsi Arnaud Ebalard
     [not found]     ` <e1c3f3fbd9f494fa228de3ee5928c771d33b072e.1416351426.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
2014-11-20  1:55       ` Jason Cooper
     [not found]         ` <20141120015519.GA22670-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-11-20  5:02           ` Andrew Lunn
     [not found]             ` <20141120050213.GB2596-g2DYL2Zd6BY@public.gmane.org>
2014-11-20  7:35               ` Arnd Bergmann
2014-11-20  8:28                 ` Arnaud Ebalard
2014-11-21 20:24               ` Jason Cooper
2014-11-18 23:01   ` [PATCHv4 02/10] arm: mvebu: add uartX labels for Armada SoC serial nodes Arnaud Ebalard
     [not found]     ` <8c622c408d74d5e9fc36b7c00f9e8aeb3f290683.1416351426.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
2014-11-19 12:16       ` Thomas Petazzoni
2014-11-18 23:01   ` [PATCHv4 03/10] arm: mvebu: use recently introduced uart label for stdout-path Arnaud Ebalard
     [not found]     ` <206fa4769a1e02f3e6b139160cd5dd9d25c90837.1416351426.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
2014-11-19 12:16       ` Thomas Petazzoni
2014-11-18 23:02   ` [PATCHv4 04/10] arm: mvebu: move Armada 370/XP pinctrl node definition armada-370-xp.dtsi Arnaud Ebalard
     [not found]     ` <f4b15c942f543b0c0becd7c82bce07e9e0b603cf.1416351426.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
2014-11-19  8:03       ` Uwe Kleine-König [this message]
     [not found]         ` <20141119080323.GS27002-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-11-19  8:35           ` Arnaud Ebalard
2014-11-18 23:02   ` [PATCHv4 05/10] arm: mvebu: define and use common Armada 370 SPI pinctrl settings Arnaud Ebalard
2014-11-18 23:02   ` [PATCHv4 06/10] arm: mvebu: define and use common Armada 370 UART " Arnaud Ebalard
2014-11-18 23:02   ` [PATCHv4 07/10] arm: mvebu: define and use common Armada XP UART2/3 " Arnaud Ebalard
2014-11-18 23:02   ` [PATCHv4 08/10] arm: mvebu: define and use common Armada XP SPI pinctrl setting Arnaud Ebalard
2014-11-18 23:02   ` [PATCHv4 09/10] arm: mvebu: add .dts file for Synology DS213j Arnaud Ebalard
2014-11-18 23:03   ` [PATCHv4 10/10] arm: mvebu: add .dts file for Synology DS414 Arnaud Ebalard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141119080323.GS27002@pengutronix.de \
    --to=u.kleine-koenig-bicnvbalz9megne8c9+irq@public.gmane.org \
    --cc=andrew-g2DYL2Zd6BY@public.gmane.org \
    --cc=arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
    --cc=klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    --cc=sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).