From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v12 1/3] drm: rockchip: Add basic drm driver Date: Wed, 19 Nov 2014 14:17:58 +0100 Message-ID: <20141119131758.GN25711@phenom.ffwll.local> References: <1416297587-18959-1-git-send-email-mark.yao@rock-chips.com> <1416297629-19024-1-git-send-email-mark.yao@rock-chips.com> <20141118083234.GZ25711@phenom.ffwll.local> <20141118142130.6c12ab50@bbrezillon> <20141118142447.GC25711@phenom.ffwll.local> <546BEDD9.1000205@rock-chips.com> <546BFA4D.3090700@rock-chips.com> <20141119100413.7ab613e9@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20141119100413.7ab613e9@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Brezillon Cc: Mark Rutland , heiko@sntech.de, linux-doc@vger.kernel.org, kever.yang@rock-chips.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, xxm@rock-chips.com, linux-rockchip@lists.infradead.org, Grant Likely , huangtao@rock-chips.com, devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Kumar Gala , yxj@rock-chips.com, Rob Herring , marcheu@chromium.org, Mark yao , xw@rock-chips.com, linux-api@vger.kernel.org, Randy Dunlap , dianders@chromium.org, Greg Kroah-Hartman , cf@rock-chips.com List-Id: devicetree@vger.kernel.org T24gV2VkLCBOb3YgMTksIDIwMTQgYXQgMTA6MDQ6MTNBTSArMDEwMCwgQm9yaXMgQnJlemlsbG9u IHdyb3RlOgo+IEFGQUlVLCB0aGUgc3VnZ2VzdGlvbiB3YXMgdG8gc3BsaXQgZHJtX2Nvbm5lY3Rv cl9pbml0IGFuZAo+IGRybV9jb25uZWN0b3JfcmVnaXN0ZXIgY2FsbHM6Cj4gIC0gZHJtX2Nvbm5l Y3Rvcl9pbml0IGNhbGwgc2hvdWxkIHN0aWxsIGJlIHBhcnQgb2YgdGhlIGxvYWQgcHJvY2VkdXJl Cj4gICAgKHRoaXMgZnVuY3Rpb24gYWRkcyB0aGUgY29ubmVjdG9yIHRvIHRoZSBjb25uZWN0b3Ig bGlzdCB3aGljaCBpcyB1c2VkCj4gICAgYnkgZHJtX21vZGVfZ3JvdXBfaW5pdF9sZWdhY3lfZ3Jv dXApCj4gIC0gZHJtX2Nvbm5lY3Rvcl9yZWdpc3RlciBzaG91bGQgYmUgY2FsbGVkIGFmdGVyIHRo ZSBkZXZpY2UgaGFzIGJlZW4KPiAgICByZWdpc3RlcmVkCj4gCj4gSGVyZSB3aGF0IEkndmUgZG9u ZSBhbmQgaXQgc2VlbXMgdG8gd29yazoKPiAKPiBzdGF0aWMgaW50IGF0bWVsX2hsY2RjX2RjX2Nv bm5lY3Rvcl9wbHVnX2FsbChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+IHsKPiAJc3RydWN0IGRy bV9jb25uZWN0b3IgKmNvbm5lY3RvciwgKmZhaWxlZDsKPiAJaW50IHJldDsKPiAKPiAJbXV0ZXhf bG9jaygmZGV2LT5tb2RlX2NvbmZpZy5tdXRleCk7Cj4gCWxpc3RfZm9yX2VhY2hfZW50cnkoY29u bmVjdG9yLAo+IAkmZGV2LT5tb2RlX2NvbmZpZy5jb25uZWN0b3JfbGlzdCwgaGVhZCkgeyByZXQg PQo+IAlkcm1fY29ubmVjdG9yX3JlZ2lzdGVyKGNvbm5lY3Rvcik7IGlmIChyZXQpIHsKPiAJCQlm YWlsZWQgPSBjb25uZWN0b3I7Cj4gCQkJZ290byBlcnI7Cj4gCQl9Cj4gCX0KPiAJbXV0ZXhfdW5s b2NrKCZkZXYtPm1vZGVfY29uZmlnLm11dGV4KTsKPiAJcmV0dXJuIDA7Cj4gCj4gZXJyOgo+IAls aXN0X2Zvcl9lYWNoX2VudHJ5KGNvbm5lY3RvciwgJmRldi0+bW9kZV9jb25maWcuY29ubmVjdG9y X2xpc3QsIGhlYWQpIHsKPiAJCWlmIChmYWlsZWQgPT0gY29ubmVjdG9yKQo+IAkJCWJyZWFrOwo+ IAo+IAkJZHJtX2Nvbm5lY3Rvcl91bnJlZ2lzdGVyKGNvbm5lY3Rvcik7Cj4gCX0KPiAJbXV0ZXhf dW5sb2NrKCZkZXYtPm1vZGVfY29uZmlnLm11dGV4KTsKPiAKPiAJcmV0dXJuIHJldDsKPiB9Cj4g Cj4gWy4uLl0KPiAKPiBzdGF0aWMgaW50IGF0bWVsX2hsY2RjX2RjX2RybV9wcm9iZShzdHJ1Y3Qg cGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+IHsKPiAJc3RydWN0IGRybV9kZXZpY2UgKmRkZXY7Cj4g CWludCByZXQ7Cj4gCj4gCWRkZXYgPSBkcm1fZGV2X2FsbG9jKCZhdG1lbF9obGNkY19kY19kcml2 ZXIsICZwZGV2LT5kZXYpOwo+IAlpZiAoIWRkZXYpCj4gCQlyZXR1cm4gLUVOT01FTTsKPiAKPiAJ cmV0ID0gZHJtX2Rldl9zZXRfdW5pcXVlKGRkZXYsIGRldl9uYW1lKGRkZXYtPmRldikpOwo+IAlp ZiAocmV0KQo+IAkJZ290byBlcnJfdW5yZWY7Cj4gCj4gCXJldCA9IGF0bWVsX2hsY2RjX2RjX2xv YWQoZGRldik7Cj4gCWlmIChyZXQpCj4gCQlnb3RvIGVycl91bnJlZjsKPiAKPiAJcmV0ID0gZHJt X2Rldl9yZWdpc3RlcihkZGV2LCAwKTsKPiAJaWYgKHJldCkKPiAJCWdvdG8gZXJyX3VubG9hZDsK PiAKPiAJcmV0ID0gYXRtZWxfaGxjZGNfZGNfY29ubmVjdG9yX3BsdWdfYWxsKGRkZXYpOwo+IAlp ZiAocmV0KQo+IAkJZ290byBlcnJfdW5yZWdpc3RlcjsKPiAKPiAJcmV0dXJuIDA7Cj4gCj4gZXJy X3VucmVnaXN0ZXI6Cj4gCWRybV9kZXZfdW5yZWdpc3RlcihkZGV2KTsKPiAKPiBlcnJfdW5sb2Fk Ogo+IAlhdG1lbF9obGNkY19kY191bmxvYWQoZGRldik7Cj4gCj4gZXJyX3VucmVmOgo+IAlkcm1f ZGV2X3VucmVmKGRkZXYpOwo+IAo+IAlyZXR1cm4gcmV0Owo+IH0KPiAKPiBEYW5pZWwsIGNhbiB5 b3UgY29uZmlybSB0aGF0J3Mgd2hhdCB5b3UgaGFkIGluIG1pbmQgPwoKWXVwLiBUbyBiZSBhYmxl IHRvIGhhdmUgcmFjZS1mcmVlIGRyaXZlciBsb2FkIHdlIG5lZWQgdG8gc3BsaXQgb2JqZWN0Cmlu dG8gYW4gX2luaXQgc3RlcCAoYWxsb2NhdGVzIHN0cnVjdHMgYW5kIGxpbmtzIHRvIGtlcm5lbC1p bnRlcm5hbCBsaXN0cykKYW5kIF9yZWdpc3RlciAobWFrZXMgdGhlIG9iamVjdCB1c2Vyc3BhY2Ut dmlzaWJsZSB0aHJvdWdoIHN5c2ZzIGFuZApkZXYtbm9kZSBrbXMgb2JqZWN0IGxvb2t1cCBpZHIp LgoKVGhpcyBlbnRpcmUgbWVzcyBpcyBhbGwgc3RpbGwgZmFsbG91dCBmcm9tIHRoZSBkYXJrIGFn ZXMgb2YgdGhlIGRybQptaWRsYXllciBhbmQgd2UnbGwgcHJvYmFibHkgaGF2ZSBmdW4gd2l0aCB0 aGlzIGZvciBhbm90aGVyIGZldyB5ZWFycyA7LSkKLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpT b2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KKzQxICgwKSA3OSAzNjUgNTcgNDgg LSBodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo=