From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCHv2 3/5] clk: s2mps11: Add the support for S2MPS13 PMIC clock Date: Wed, 19 Nov 2014 16:43:10 +0000 Message-ID: <20141119164310.GH1875@x1> References: <1416301183-10478-1-git-send-email-cw00.choi@samsung.com> <1416301183-10478-4-git-send-email-cw00.choi@samsung.com> <20141118215926.25314.90810@quantum> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20141118215926.25314.90810@quantum> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mike Turquette Cc: Chanwoo Choi , broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sbkim73-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, geunsik.lim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, 18 Nov 2014, Mike Turquette wrote: > Quoting Chanwoo Choi (2014-11-18 00:59:41) > > This patch adds the support for S2MPS13 PMIC clock which is same wi= th existing > > S2MPS14 RTC IP. But, S2MPS13 uses all of clocks (32khz_{ap|bt|cp}). > >=20 > > Cc: Mike Turquette > > Signed-off-by: Chanwoo Choi > > Reviewed-by: Krzysztof Kozlowski >=20 > Applied to clk-next. I'm pretty sure you can't do that. You have a dependency on linux/mfd/samsung/s2mps13.h, which is satisfied in one of the earlier patches in the set. If you'd care to just provide an Ack for this patch, I can send you a pull-request with the decencies met. > > --- > > drivers/clk/clk-s2mps11.c | 24 ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > >=20 > > diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c > > index b7797fb..7bb13af 100644 > > --- a/drivers/clk/clk-s2mps11.c > > +++ b/drivers/clk/clk-s2mps11.c > > @@ -23,6 +23,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -120,6 +121,24 @@ static struct clk_init_data s2mps11_clks_init[= S2MPS11_CLKS_NUM] =3D { > > }, > > }; > > =20 > > +static struct clk_init_data s2mps13_clks_init[S2MPS11_CLKS_NUM] =3D= { > > + [S2MPS11_CLK_AP] =3D { > > + .name =3D "s2mps13_ap", > > + .ops =3D &s2mps11_clk_ops, > > + .flags =3D CLK_IS_ROOT, > > + }, > > + [S2MPS11_CLK_CP] =3D { > > + .name =3D "s2mps13_cp", > > + .ops =3D &s2mps11_clk_ops, > > + .flags =3D CLK_IS_ROOT, > > + }, > > + [S2MPS11_CLK_BT] =3D { > > + .name =3D "s2mps13_bt", > > + .ops =3D &s2mps11_clk_ops, > > + .flags =3D CLK_IS_ROOT, > > + }, > > +}; > > + > > static struct clk_init_data s2mps14_clks_init[S2MPS11_CLKS_NUM] =3D= { > > [S2MPS11_CLK_AP] =3D { > > .name =3D "s2mps14_ap", > > @@ -184,6 +203,10 @@ static int s2mps11_clk_probe(struct platform_d= evice *pdev) > > s2mps11_reg =3D S2MPS11_REG_RTC_CTRL; > > clks_init =3D s2mps11_clks_init; > > break; > > + case S2MPS13X: > > + s2mps11_reg =3D S2MPS13_REG_RTCCTRL; > > + clks_init =3D s2mps13_clks_init; > > + break; > > case S2MPS14X: > > s2mps11_reg =3D S2MPS14_REG_RTCCTRL; > > clks_init =3D s2mps14_clks_init; > > @@ -279,6 +302,7 @@ static int s2mps11_clk_remove(struct platform_d= evice *pdev) > > =20 > > static const struct platform_device_id s2mps11_clk_id[] =3D { > > { "s2mps11-clk", S2MPS11X}, > > + { "s2mps13-clk", S2MPS13X}, > > { "s2mps14-clk", S2MPS14X}, > > { "s5m8767-clk", S5M8767X}, > > { }, --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html