From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v7 4/4] dt-bindings: add bindings for mediatek sysirq Date: Wed, 19 Nov 2014 18:07:25 +0000 Message-ID: <20141119180724.GE12851@leverpostej> References: <1416406451-4578-1-git-send-email-yingjoe.chen@mediatek.com> <1416406451-4578-5-git-send-email-yingjoe.chen@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1416406451-4578-5-git-send-email-yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yingjoe Chen Cc: Thomas Gleixner , Jiang Liu , Marc Zyngier , Boris BREZILLON , Russell King , Jason Cooper , Pawel Moll , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "hc.yen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org" , "srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org" , "yh.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , Yijing Wang , Rob Herring , "nathan.chung-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org" , "yingjoe.chen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , Matthias Brugger , "eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org" List-Id: devicetree@vger.kernel.org On Wed, Nov 19, 2014 at 02:14:11PM +0000, Yingjoe Chen wrote: > Add binding documentation for Mediatek SoC SYSIRQ. > > Signed-off-by: Yingjoe Chen > --- > .../bindings/arm/mediatek/mediatek,sysirq.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt > > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt > new file mode 100644 > index 0000000..8669536 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt > @@ -0,0 +1,26 @@ > +Mediatek 65xx/81xx sysirq > + > +Mediatek SOCs sysirq support controllable irq inverter for each GIC SPI > +interrupt. > + > +Required properties: > +- compatible: should be one of: > + "mediatek,mt8135-sysirq" > + "mediatek,mt8127-sysirq" > + "mediatek,mt6589-sysirq" > + "mediatek,mt6582-sysirq" > + "mediatek,mt6577-sysirq" > +- interrupt-controller : Identifies the node as an interrupt controller > +- #interrupt-cells : Must use the same cells/format as parent controller. > +- interrupt-parent: phandle of irq domain parent for sysirq. I'm concerned that this sounds very general while the binding assumes the GICv2 interrupt-specifier format. Either the driver needs to become more general, or this needs to be tightened up. It's also odd to say "irq domain parent", as that's purely a Linux construct and has nothing to do with the HW. Thanks, Mark. > +- reg: Physical base address of the intpol registers and length of memory > + mapped region. > + > +Example: > + sysirq: interrupt-controller@10200100 { > + compatible = "mediatek,mt6589-sysirq", "mediatek,mt6577-sysirq"; > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + reg = <0 0x10200100 0 0x1c>; > + }; > -- > 1.8.1.1.dirty > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html