From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 2/7] mfd: MT6397: Add regmap for MT8135 and MT6397 SoC Date: Thu, 20 Nov 2014 10:38:44 +0000 Message-ID: <20141120103844.GA13269@x1> References: <1416210027-5562-1-git-send-email-flora.fu@mediatek.com> <1416210027-5562-3-git-send-email-flora.fu@mediatek.com> <20141118114645.GX24004@x1> <20141118134618.GF30369@pengutronix.de> <20141119170454.GJ1875@x1> <20141120091943.GJ30369@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20141120091943.GJ30369-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sascha Hauer Cc: Flora Fu , Rob Herring , Mark Rutland , Matthias Brugger , Pawel Moll , Ian Campbell , Kumar Gala , Russell King , Samuel Ortiz , Liam Girdwood , Mark Brown , Grant Likely , "Joe.C" , Catalin Marinas , Vladimir Murzin , Ashwin Chaugule , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Sascha Hauer , Eddie Huang , Dongdong Cheng List-Id: devicetree@vger.kernel.org On Thu, 20 Nov 2014, Sascha Hauer wrote: > On Wed, Nov 19, 2014 at 05:04:54PM +0000, Lee Jones wrote: > > On Tue, 18 Nov 2014, Sascha Hauer wrote: > >=20 > > > On Tue, Nov 18, 2014 at 11:46:45AM +0000, Lee Jones wrote: > > > > On Mon, 17 Nov 2014, Flora Fu wrote: > > > >=20 > > > > > Add PMIC wrapper of MT8135 to access MFD MT6397. > > > > > This is regmap of MT6397 MFD. > > > > >=20 > > > > > Signed-off-by: Flora Fu > > > > > --- > > > > > drivers/mfd/Kconfig | 8 + > > > > > drivers/mfd/Makefile | 1 + > > > > > drivers/mfd/mt8135-pmic-wrap.c | 847 +++++++++++++++++++++++= ++++++++++++++++++ > > > >=20 > > > > All of the PMIC functionality needs removing from MFD and place= d > > > > somewhere else. I suggest either drivers/power or drivers/regu= lator. > > >=20 > > > This is no PMIC functionality. The MT8135 has a unit which is is = used to > > > access the PMIC (which is not only a PMIC, but also Touchscreen > > > interface and other stuff). This unit is called pmic-wrapper in t= he > > > docs. See the introductory mail for a nice picture. > >=20 > > I saw the picture, it's very nice. Whatever this is, it's not an > > MFD. It's a device which is located on an MFD. There is far too m= uch > > functional (the operative word here) code contained in this patch. >=20 > The MT6397 is a classical MFD device. It has a PMIC, an audio amp and= a > RTC. It is very tightly coupled to the SoC via SPI, but the SPI itsel= f > is not directly visible on the SoC. It's accessible indirectly via th= e > PMIC-wrapper. Indeed the PMIC-wrapper is not MFD. Another dumping gro= und > that comes to my mind is drivers/soc/. We could move over there. Thanks for understanding my point-of-view. Hopefully there is a suitable "dumping ground", or even better a proper place to move the PMIC-wrapper to. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html