From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCHv4 1/1] thermal: of: improve of-thermal sensor registration API Date: Thu, 20 Nov 2014 09:52:32 -0400 Message-ID: <20141120135155.GB24778@developer> References: <1416321575-18348-1-git-send-email-edubezval@gmail.com> <1416321575-18348-2-git-send-email-edubezval@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="c3bfwLpm8qysLVxt" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexandre Courbot Cc: Linux PM , Caesar Wang , Wei Ni , Lukasz Majewski , Mikko Perttunen , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Grant Likely , Guenter Roeck , Jean Delvare , Linux Kernel Mailing List , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org, Rob Herring , Stephen Warren , Thierry Reding , Zhang Rui List-Id: devicetree@vger.kernel.org --c3bfwLpm8qysLVxt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Alexander, On Wed, Nov 19, 2014 at 05:06:24PM +0900, Alexandre Courbot wrote: > On Tue, Nov 18, 2014 at 11:39 PM, Eduardo Valentin = wrote: > > Different drivers request API extensions in of-thermal. For this reason, > > additional callbacks are required to fit the new drivers needs. > > > > The current API implementation expects the registering sensor driver > > to provide a get_temp and get_trend callbacks as function parameters. > > As the amount of callbacks is growing, this patch changes the existing > > implementation to use a .ops field to hold all the of thermal callbacks > > to sensor drivers. > > > > This patch also changes the existing of-thermal users to fit the new > > API design. No functional change is introduced in this patch. >=20 > A good idea even if no ops were to be added! >=20 > Reviewed-by: Alexandre Courbot Thanks for reviewing. Eduardo Valentin --c3bfwLpm8qysLVxt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUbfIeAAoJEMLUO4d9pOJWV48H/0hSblonH5J96HEdJgx5O5y9 NBKK0ulyOQMn5xGoD6cvowht+oF3ViTFDpq0/Uvjg2I5QMMyB8JOGNUPlIS58Eq4 OlMz4VGEh77l6HFosEeeXDiOslb+sLZi79LBfaCp4vkPuifRnT6WUAc+QYSXUjuc 5QyL8aXypQr98Vu6YOlnpLNSC0KjkFJcdTviXY7kO3r78MNm1Htt3VGCoW/X5FR9 jXDZWX/P0bq4Kvu5+j+ADPuZjSkAmEUc6Jm5RPQo0nXtVDHGfLojNYHc2kVIlVH8 bXYJXik+Wt5KpAWivF3lTvj6NIMhis5oWJHhZARLz/uL30UjX2Im+wVD1jSAtcc= =Kf2R -----END PGP SIGNATURE----- --c3bfwLpm8qysLVxt--