Re: [PATCH] Add attributes neccessary for LED flashes to devicetree/bindings/leds/common.txt

[Pavel Machek <pavel@ucw.cz>]

On Thu 2014-11-20 14:38:11, Jacek Anaszewski wrote:
> Hi Pavel,
> 
> On 11/20/2014 02:17 PM, Pavel Machek wrote:
> >
> >Add attributes neccessary for LED flashes to
> >devicetree/bindings/leds/common.txt .
> >
> >This will allow me to add device tree support for adp1653 i2c flash
> >LED driver, and allow Jacek Anaszewski to add support for more LED
> >drivers..
> >
> >Signed-off-by: Pavel Machek <pavel@ucw.cz>
> >
> >diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
> >index 2d88816..e9acbbc 100644
> >--- a/Documentation/devicetree/bindings/leds/common.txt
> >+++ b/Documentation/devicetree/bindings/leds/common.txt
> >@@ -14,6 +14,15 @@ Optional properties for child nodes:
> >       "ide-disk" - LED indicates disk activity
> >       "timer" - LED flashes at a fixed, configurable rate
> >
> >+- max-microamp : maximum intensity in microamperes of the LED
> >+  	         (torch LED for flash devices)
> >+- flash-max-microamp : maximum intensity in microamperes of the
> >+                       flash LED; it is mandatory if the LED should
> >+		       support the flash mode
> >+- flash-timeout-microsec : timeout in microseconds after which the flash
> >+                           LED is turned off
> >+
> >+
> >  Examples:
> >
> >  system-status {
> >@@ -21,3 +30,10 @@ system-status {
> >  	linux,default-trigger = "heartbeat";
> >  	...
> >  };
> >+
> >+camera-flash {
> >+	label = "Flash";
> >+	max-microamp = <50000>;
> >+	flash-max-microamp = <320000>;
> >+	flash-timeout-microsec = <500000>;
> >+}
> >
> 
> Why did you omit indicator-pattern?

Well, I think its going to be device specific, and it was not
specified well enough -- and I believe it needs more discussion.

Indicator pattern would be basically some sequence of intensities in
time, right?

And your hardware has some preset number of patterns it can do...?

There's a controller for 3-color LED in n900, and it takes programs
for patterns. So I for example had a program that computed prime
numbers and then blinked them on the LED, independently of the main
CPU.

So yes, patterns would be useful, but no, I don't know how to do them
in generic way, and thus would prefer to avoid defining them in
generic binding.

									Pavel



-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html