Re: [PATCH v1] usb: phy: nop: device tree documentation for vbus

[Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]

On Sun, Nov 09, 2014 at 02:02:18PM +0100, Robert Jarzmik wrote:
> Enhance the phy documentation by adding 2 new optional bindings :
>  - the vbus gpio, which detects usb insertion
>  - the vbus regulator, which provides current drawn from the usb cable
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt
> index 1bd37fa..65dfe4b 100644
> --- a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt
> @@ -17,6 +17,11 @@ Optional properties:
>  
>  - reset-gpios: Should specify the GPIO for reset.
>  
> +- vbus-gpios: should specify the GPIO detecting a VBus insertion
> +              (see Documentation/devicetree/bindings/gpio/gpio.txt)
> +- vbus-regulator : should specifiy the regulator supplying current drawn from
> +  the VBus line (see Documentation/devicetree/bindings/regulator/regulator.txt).
> +
>  Example:
>  
>  	hsusb1_phy {
> @@ -26,8 +31,11 @@ Example:
>  		clock-names = "main_clk";
>  		vcc-supply = <&hsusb1_vcc_regulator>;
>  		reset-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;
> +		vbus-gpios = <&gpio2 13 GPIO_ACTIVE_HIGH>;
> +		vbus-regulator = <&vbus_regulator>;

not sure why you need vbus-gpios here. You can pass the gpio to the
regulator as enable-gpio, right ?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]