devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Romain Perier <romain.perier@gmail.com>
Cc: "Johan Hovold" <johan@kernel.org>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Mark Brown" <broonie@kernel.org>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Grant Likely" <grant.likely@linaro.org>, robh <robh@kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Felipe Balbi" <balbi@ti.com>
Subject: Re: [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller"
Date: Mon, 24 Nov 2014 14:21:00 +0100	[thread overview]
Message-ID: <20141124132100.GD6875@localhost> (raw)
In-Reply-To: <CABgxDoLA=QL6vzU-v1w4vMZ3qhorjRdYOWFFMrjJE6xvZ7QO3g@mail.gmail.com>

On Mon, Nov 24, 2014 at 01:58:50PM +0100, Romain Perier wrote:
> 2014-11-24 12:35 GMT+01:00 Johan Hovold <johan@kernel.org>:

> > You should also fix the commit message, which claims to define a "helper
> > function which is compatible with both properties", something which was
> > no longer the case.
> >
> So I need to resend this patch which would only introduce an helper
> function which checks for "system-power-controller" property (it would
> also have a new commit message).
> As you suggested, this helper might be named
> "of_device_is_system_power_controller" ?

Correct. Rename the helper and property name you introduced to
"of_device_is_system_power_controller" and "system-power-controller" and
update the act8865 driver to use the new names (all in one patch).

Send the patch to Mark (and keep everyone else one CC) so he can apply
it to the regulator tree.

Other drivers that are currently using "ti,system-power-controller" can
continue to do so (for backward compatibility), while we later also add
a call to your helper function (and update binding documentation) and
also update the device trees for boards that use this functionality.

Thanks,
Johan

  parent reply	other threads:[~2014-11-24 13:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13 13:34 [PATCH v4 0/2] poweroff-source DT property renaming Auto Configured
2014-11-13 13:34 ` [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller" Auto Configured
2014-11-13 20:55   ` Grant Likely
2014-11-14  7:22     ` Romain Perier
2014-11-17 10:51       ` Romain Perier
2014-11-20 10:44         ` Romain Perier
2014-11-21 10:59   ` Johan Hovold
2014-11-21 11:00     ` [PATCH] Revert "mfd: tps65910: Convert ti,system-power-controller DT property to poweroff-source" Johan Hovold
2014-11-21 13:18     ` [PATCH v4 1/2] of: Rename "poweroff-source" property to "system-power-controller" Romain Perier
2014-11-21 13:22       ` Romain Perier
2014-11-24 10:24     ` Lee Jones
2014-11-24 11:35       ` Johan Hovold
2014-11-24 12:58         ` Romain Perier
2014-11-24 13:01           ` Romain Perier
2014-11-24 13:12             ` Heiko Stübner
2014-11-24 13:21           ` Johan Hovold [this message]
2014-11-13 13:34 ` [PATCH v4 2/2] dt-bindings: Update documentation for "system-power-controller" and fix misspellings Auto Configured

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141124132100.GD6875@localhost \
    --to=johan@kernel.org \
    --cc=balbi@ti.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=heiko@sntech.de \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    --cc=romain.perier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).