From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH] Add attributes neccessary for LED flashes to devicetree/bindings/leds/common.txt Date: Mon, 24 Nov 2014 23:53:19 +0100 Message-ID: <20141124225319.GA22383@amd> References: <20141120131713.GC27527@amd> <546DEEC3.7090508@samsung.com> <546DFF3A.7020702@samsung.com> <20141120205254.GA19174@amd> <546EF4A3.2000101@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <546EF4A3.2000101@samsung.com> Sender: linux-leds-owner@vger.kernel.org To: Jacek Anaszewski Cc: sakari.ailus@iki.fi, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, rob@landley.net List-Id: devicetree@vger.kernel.org On Fri 2014-11-21 09:15:31, Jacek Anaszewski wrote: > Hi Pavel, > > On 11/20/2014 09:52 PM, Pavel Machek wrote: > >On Thu 2014-11-20 15:48:26, Jacek Anaszewski wrote: > >>On 11/20/2014 02:38 PM, Jacek Anaszewski wrote: > >>>Hi Pavel, > >>> > >>>On 11/20/2014 02:17 PM, Pavel Machek wrote: > >>>> > >>>>Add attributes neccessary for LED flashes to > >>>>devicetree/bindings/leds/common.txt . > >>>> > >>>>This will allow me to add device tree support for adp1653 i2c flash > >>>>LED driver, and allow Jacek Anaszewski to add support for more LED > >>>>drivers.. > >.. > >> > >>Actually, we've agreed with Sakari that we can handle > >>indicator-pattern later. > > > >Good. > > > >>I would remove references to you, me and adp1653 driver from the commit > >>message and mention that this modifications adjust the led common > >>bindings to the LED Flash class that is to be added. > > > >Ok, who can take this patch? Can you edit the changelog, or should I > >do it? Anything else that needs changing? > > It's your patch :) For me the contents of the patch are ok. > It requires device tree maintainer approval anyway. Yeah, I was hoping relevant maintainers would speak up. I was not asking you to edit the changelog, sorry I was unclear. Bryan Wu, Richard Purdie: You are the maintainers. Can you take the patch? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html