From: Johan Hovold <johan@kernel.org>
To: Grant Likely <grant.likely@linaro.org>
Cc: Romain Perier <romain.perier@gmail.com>,
heiko@sntech.de, johan@kernel.org, lee.jones@linaro.org,
broonie@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
lgirdwood@gmail.com, mark.rutland@arm.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, balbi@ti.com
Subject: Re: [PATCH v5 1/2] of: Rename "poweroff-source" property to "system-power-controller"
Date: Tue, 25 Nov 2014 15:54:10 +0100 [thread overview]
Message-ID: <20141125145410.GD19910@localhost> (raw)
In-Reply-To: <20141125144007.9904BC44343@trevor.secretlab.ca>
On Tue, Nov 25, 2014 at 02:40:07PM +0000, Grant Likely wrote:
> On Tue, 25 Nov 2014 12:28:25 +0000
> , Romain Perier <romain.perier@gmail.com>
> wrote:
> > It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability").
> > As discussed on the mailing list, it makes more sense to rename back to the
> > old established property name, without the vendor prefix. Problem being that
> > the word "source" usually tends to be used for inputs and that is out of control
> > of the OS. The poweroff capability is an output which simply turns the
> > system-power off. Also, this property might be used by drivers which power-off
> > the system and power back on subsequent RTC alarms. This seems to suggest to
> > remove "poweroff" from the property name and to choose "system-power-controller"
> > as the more generic name. This patchs adds the required renaming changes and
> > defines an helper function which checks if this property is set.
> >
> > Signed-off-by: Romain Perier <romain.perier@gmail.com>
>
> For both patches:
> Acked-by: Grant Likely <grant.likely@linaro.org>
>
> Let me know if I need to take this series through my tree. Also, does it
> need to go into v3.18 and be backported to stable? Or just v3.19.
It's only needed in the regulator tree for 3.19, and does not need to be
backported.
We could convert the drivers (and dts) that currently use
"<vendor>,system-power-controller" to use the new helper (while
maintaining backward compatibility) after 3.19-rc1 is out.
Johan
next prev parent reply other threads:[~2014-11-25 14:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 12:28 [PATCH v5 0/2] poweroff-source DT property renaming Romain Perier
2014-11-25 12:28 ` [PATCH v5 1/2] of: Rename "poweroff-source" property to "system-power-controller" Romain Perier
2014-11-25 14:07 ` Johan Hovold
2014-11-25 14:40 ` Grant Likely
[not found] ` <20141125144007.9904BC44343-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-11-25 14:52 ` Heiko Stübner
2014-11-25 14:54 ` Johan Hovold [this message]
2014-11-25 15:57 ` Romain Perier
2014-11-25 17:12 ` Mark Brown
2014-11-26 10:08 ` Romain Perier
2014-11-25 12:28 ` [PATCH v5 2/2] dt-bindings: Update documentation for "system-power-controller" and fix misspellings Romain Perier
2014-12-01 19:33 ` [PATCH v5 0/2] poweroff-source DT property renaming Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125145410.GD19910@localhost \
--to=johan@kernel.org \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).