From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver Date: Thu, 27 Nov 2014 20:15:52 +0100 Message-ID: <20141127191552.GS25249@lukather> References: <54743DE1.7020704@redhat.com> <20141126211318.GN25249@lukather> <20141127174056.6697cde3@bbrezillon> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="b2ktwntdbf0dPnbx" Return-path: Content-Disposition: inline In-Reply-To: <20141127174056.6697cde3@bbrezillon> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Boris Brezillon Cc: Hans de Goede , Boris Brezillon , Mike Turquette , Chen-Yu Tsai , Emilio Lopez , Linux Media Mailing List , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --b2ktwntdbf0dPnbx Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Thu, Nov 27, 2014 at 05:40:56PM +0100, Boris Brezillon wrote: > Hi, > > On Wed, 26 Nov 2014 22:13:18 +0100 > Maxime Ripard wrote: > > [...] > > > > > I remember someone (Chen-Yu? Boris?) saying that the 1wire clock was > > not really a mod0 clk. From what I could gather from the source code, > > it seems to have a wider m divider, so we could argue that it should > > need a new compatible. > > Wasn't me :-). > > Regarding the rest of the discussion I miss some context, but here's > what I remember decided us to choose the MFD approach for the PRCM > block: > > 1) it's embedding several unrelated functional blocks (reset, clk, and > some other things I don't remember). > 2) none of the functionalities provided by the PRCM were required in > the early boot stage > 3) We wanted to represent the HW blocks as they are really described in > the memory mapping instead of splitting small register chunks over the > DT. > > Can someone sum-up the current issue you're trying to solve ? There's (at least) one module0 clock exposed in the PRCM block. We have a disagreement on whether all module0 clocks should be platform drivers to support probing that one clock or just to introduce a new compatible for that one clock in the PRCM alone. > IMHO, if you really want to split those functionalities over the DT > (some nodes under clks and other under reset controller), then I > suggest to use.............. > (Maxime, please stop smiling :P) > .............. > > SYSCON We don't really need to share anything, these components are isolated in separate registers, so syscon doesn't really bring anything here. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --b2ktwntdbf0dPnbx--