From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe RICARD Subject: Re: [PATCH v4 00/15] ST33 I2C TPM driver cleanup Date: Sun, 30 Nov 2014 17:41:20 +0100 Message-ID: <20141130174120.618e9fe1@toffy-MacBookPro> References: <1413753085-9958-1-git-send-email-christophe-h.ricard@st.com> <201411301437.18703.PeterHuewe@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <201411301437.18703.PeterHuewe-Mmb7MZpHnFY@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter =?UTF-8?B?SMO8d2U=?= Cc: ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org, tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, christophe-h.ricard-qxv4g6HH51o@public.gmane.org, jean-luc.blanc-qxv4g6HH51o@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Peter, Thank you for your feedback (on Sunday :)). To be honest i missed those warnings. I figured they come when CONFIG_O= =46 is not set :/. No problem to send a v5 with tpm/tpm_i2c_stm_st33: Fix potential bug in tpm_stm_i2c_send and replace r by ret. The purpose here was more to have a kind of convention inside the driver rather than mixing r/ret/err. I hope to send this by tonight. Best Regards Christophe On Sun, 30 Nov 2014 14:37:18 +0100 Peter H=C3=BCwe wrote: > Hi Christophe, >=20 > sorry for the late reply :/ > =20 > > This new patchset version is taking into account as much as possibl= e > > Jason Gunthorpe feedbacks. I hope, i am not missing any. > >=20 > > It still brings: > > - Some few code clean up from code style up to structure > > - Device tree support keeping static platform data configuration > > support. > > - Fixes & improvement for irq support. > > - Update the GPLv2 license header > >=20 > > I am also adding the mention Reviewed-By: Jason Gunthorpe > > on all those patches. > > Jason, please feel free to let me know if i am mistaking here. :). > >=20 > > This patchset apply on top of James Morris linux-security tree >=20 > Unfortunately I get compile warnings: >=20 > /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_stm_st33.c: In > function 'tpm_stm_i2c_probe': > /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_stm_st33.c:748:3: > warning: passing argument 1 of 'tpm_stm_i2c_of_request_resources' > from incompatible pointer type [enabled by default] > /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_stm_st33.c:670:12: > note: expected 'struct i2c_client *' but argument is of type 'struct > tpm_chip > *' /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_stm_st33.c:722:3= : > warning: 'chip' may be used uninitialized in this function > [-Wuninitialized] >=20 > Smatch complains: > /data/data-old/linux-2.6/drivers/char/tpm/tpm_i2c_stm_st33.c:722=20 > tpm_stm_i2c_probe() error: potentially dereferencing uninitialized > 'chip'. >=20 >=20 >=20 > Can you fix this up? >=20 > (also if you redo the patchset, moving=20 > tpm/tpm_i2c_stm_st33: Fix potential bug in tpm_stm_i2c_send > to the front would be nice, as indicated by Jason on v3 >=20 >=20 > Nitpick: maybe you could use ret instead of r in your return code > cleanup. I'm not a fan of one letter variables, except counters) >=20 >=20 > Peter >=20 >=20 -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html