From: "Peter Hüwe" <PeterHuewe-Mmb7MZpHnFY@public.gmane.org>
To: Christophe RICARD
<christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org,
tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
christophe-h.ricard-qxv4g6HH51o@public.gmane.org,
jean-luc.blanc-qxv4g6HH51o@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org
Subject: Re: [PATCH v4 00/15] ST33 I2C TPM driver cleanup
Date: Sun, 30 Nov 2014 18:47:04 +0100 [thread overview]
Message-ID: <201411301847.04422.PeterHuewe@gmx.de> (raw)
In-Reply-To: <20141130174120.618e9fe1@toffy-MacBookPro>
Hi Christophe,
> Thank you for your feedback (on Sunday :)).
>
> To be honest i missed those warnings. I figured they come when CONFIG_OF
> is not set :/.
>
> No problem to send a v5 with tpm/tpm_i2c_stm_st33: Fix potential bug in
> tpm_stm_i2c_send and replace r by ret. The purpose here was more to
> have a kind of convention inside the driver rather than mixing
> r/ret/err.
>
> I hope to send this by tonight.
Would be great! - usually I try to sort this stuff out myself, but this is not
possible at the moment.
Thanks,
Peter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-11-30 17:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 21:11 [PATCH v4 00/15] ST33 I2C TPM driver cleanup Christophe Ricard
[not found] ` <1413753085-9958-1-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2014-10-19 21:11 ` [PATCH v4 01/15] tpm/tpm_i2c_stm_st33: Update Kconfig in order to be inline to other similar product Christophe Ricard
2014-10-19 21:11 ` [PATCH v4 02/15] tpm/tpm_i2c_stm_st33: Fix few coding style error reported by scripts/checkpatch.pl Christophe Ricard
2014-10-19 21:11 ` [PATCH v4 03/15] tpm/tpm_i2c_stm_st33: Move tpm registers to tpm_i2c_stm_st33.c Christophe Ricard
2014-10-19 21:11 ` [PATCH v4 04/15] tpm/tpm_i2c_stm_st33: Add new tpm_stm_dev structure and remove tpm_i2c_buffer[0], [1] buffer Christophe Ricard
2014-10-19 21:11 ` [PATCH v4 05/15] tpm/tpm_i2c_stm_st33: Remove reference to io_serirq Christophe Ricard
2014-10-19 21:11 ` [PATCH v4 06/15] tpm/tpm_i2c_stm_st33: Replace err/rc/ret by r for a function return code Christophe Ricard
2014-10-19 21:11 ` [PATCH v4 07/15] tpm/tpm_i2c_stm_st33: Replace tpm_st33_* function with tpm_stm_* Christophe Ricard
2014-10-19 21:11 ` [PATCH v4 08/15] tpm/tpm_i2c_stm_st33: Add devicetree structure Christophe Ricard
2014-10-19 21:11 ` [PATCH v4 09/15] tpm/tpm_i2c_stm_st33/dts/st33zp24_i2c: Add DTS Documentation Christophe Ricard
[not found] ` <1413753085-9958-10-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2014-11-30 12:55 ` Peter Hüwe
2014-10-19 21:11 ` [PATCH v4 10/15] tpm/tpm_i2c_stm_st33: Few code cleanup Christophe Ricard
2014-10-19 21:11 ` [PATCH v4 11/15] tpm/tpm_i2c_stm_st33: Interrupt management improvement Christophe Ricard
2014-10-19 21:11 ` [PATCH v4 12/15] tpm/tpm_i2c_stm_st33: Remove useless i2c read on interrupt registers Christophe Ricard
2014-10-19 21:11 ` [PATCH v4 13/15] tpm/tpm_i2c_stm_st33: Fix potential bug in tpm_stm_i2c_send Christophe Ricard
2014-10-19 21:11 ` [PATCH v4 14/15] tpm/tpm_i2c_stm_st33: Change License header to have up to date address information Christophe Ricard
2014-10-19 21:11 ` [PATCH v4 15/15] tpm/tpm_i2c_stm_st33: Increment driver version to 1.2.1 Christophe Ricard
2014-11-30 13:37 ` [PATCH v4 00/15] ST33 I2C TPM driver cleanup Peter Hüwe
[not found] ` <201411301437.18703.PeterHuewe-Mmb7MZpHnFY@public.gmane.org>
2014-11-30 16:41 ` Christophe RICARD
2014-11-30 17:47 ` Peter Hüwe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201411301847.04422.PeterHuewe@gmx.de \
--to=peterhuewe-mmb7mzphnfy@public.gmane.org \
--cc=ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org \
--cc=christophe-h.ricard-qxv4g6HH51o@public.gmane.org \
--cc=christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jean-luc.blanc-qxv4g6HH51o@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).