From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] irqchip: gic: Allow interrupt level to be set for PPIs. Date: Mon, 1 Dec 2014 10:41:45 +0000 Message-ID: <20141201104145.GY3836@n2100.arm.linux.org.uk> References: <1417197340-27298-1-git-send-email-Liviu.Dudau@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1417197340-27298-1-git-send-email-Liviu.Dudau-5wv7dgnIgG8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Liviu Dudau Cc: Rob Herring , Mark Rutland , Ian Campbell , Thomas Gleixner , Jason Cooper , Haojian Zhuang , Marc Zyngier , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML , LAKML List-Id: devicetree@vger.kernel.org On Fri, Nov 28, 2014 at 05:55:40PM +0000, Liviu Dudau wrote: > + /* > + * PPIs are optionally configurable, but we cannot distinguish > + * between high and low, nor falling and rising. Change the > + * type so that it passes the next check. This comment could do with a /lot/ of improvement. It sounds like the only reason this code exists is to bypass the check. If that's all that's being done, there's better ways to code it. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html