devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lina Iyer <lina.iyer@linaro.org>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: daniel.lezcano@linaro.org, khilman@linaro.org,
	sboyd@codeaurora.org, galak@codeaurora.org,
	linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com,
	msivasub@codeaurora.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver
Date: Mon, 1 Dec 2014 10:57:09 -0700	[thread overview]
Message-ID: <20141201175709.GA499@linaro.org> (raw)
In-Reply-To: <1417077863.10282.3.camel@mm-sol.com>

Hi Ivan,

On Thu, Nov 27 2014 at 01:43 -0700, Ivan T. Ivanov wrote:
>
>Hi,
>
>On Wed, 2014-11-26 at 22:24 -0700, Lina Iyer wrote:
>>
>
>>  - compatible:
>> @@ -14,10 +23,13 @@ PROPERTIES
>>         Value type: <string>
>>         Definition: shall contain "qcom,saw2". A more specific value should be
>>                                                 one of:
>
>Which driver is supposed to handle this property?
>
drivers/soc/qcom/spm.c - SAW power controller driver.
>> -                               "qcom,saw2-v1"
>> -                               "qcom,saw2-v1.1"
>> -                               "qcom,saw2-v2"
>> -                               "qcom,saw2-v2.1"
>> +                       "qcom,saw2-v1"
>> +                       "qcom,saw2-v1.1"
>> +                       "qcom,saw2-v2"
>> +                       "qcom,saw2-v2.1"
>
>Doesn't seems to be used or supported?
>
Used for identify the version of the SAW that does voltage changes.  Any
SAW that can change the voltage would use one of the above compatible
strings. We only need a generic version number for regulator
functionality as opposed to the ones used for idle control (like below),
which needs to correctly identify the version number (saw2-v1.1), cpu/L2
(-cpu_variant of the SAW on a particlar SoC (qcom,apq/msmXXXX) to set
the correct register values for that SoC.

L2 SAW is currently not upstream or part of this series. Will follow
suit, when we have the power domains to control cluster low power modes.
The regulator functionality is currently not available upstream, as well
for 8084 and 8074.

Thanks,
Lina

>> +                       "qcom,apq8064-saw2-v1.1-cpu"
>> +                       "qcom,msm8974-saw2-v2.1-cpu"
>> +                       "qcom,apq8084-saw2-v2.1-cpu"
>>
>
><snip>
>
>> -       regulator@2099000 {
>> +       power-controller@2099000 {
>>                 compatible = "qcom,saw2";
>>                 reg = <0x02099000 0x1000>, <0x02009000 0x1000>;
>> +               regulator;
>>
>
><snip>
>
>> +static const struct of_device_id spm_match_table[] = {
>> +       { .compatible = "qcom,msm8974-saw2-v2.1-cpu",
>> +                       .data = &spm_reg_8974_8084_cpu },
>> +       { .compatible = "qcom,apq8084-saw2-v2.1-cpu",
>> +                       .data = &spm_reg_8974_8084_cpu },
>> +       { .compatible = "qcom,apq8064-saw2-v1.1-cpu",
>> +                       .data = &spm_reg_8064_cpu },
>> +       { },
>> +};
>> +
>
>Regards,
>Ivan

  reply	other threads:[~2014-12-01 17:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27  5:24 [PATCH v13 00/10] cpuidle driver for QCOM SoCs: 8064, 8074, 8084 Lina Iyer
2014-11-27  5:24 ` [PATCH v13 01/10] qcom: scm: Move scm-boot files to drivers/soc/qcom/ and include/soc/qcom Lina Iyer
2014-11-27  5:24 ` [PATCH v13 02/10] qcom: scm: Add SCM warmboot support for quad core SoCs Lina Iyer
2014-11-27  5:24 ` [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver Lina Iyer
2014-11-27  8:44   ` Ivan T. Ivanov
2014-12-01 17:57     ` Lina Iyer [this message]
2014-11-27  8:52   ` Daniel Lezcano
2014-12-01 18:50     ` Lina Iyer
2014-12-02  9:53       ` Daniel Lezcano
2014-12-02 15:35         ` Lina Iyer
2014-12-02 15:47           ` Daniel Lezcano
2014-11-27 15:01   ` Lorenzo Pieralisi
2014-12-01 18:57     ` Lina Iyer
2014-12-02 11:10       ` Catalin Marinas
2014-12-02 15:52         ` Lina Iyer
2014-11-27  5:24 ` [PATCH v13 04/10] arm: dts: qcom: Add power-controller device node for 8074 Krait CPUs Lina Iyer
2014-11-27  5:24 ` [PATCH v13 05/10] arm: dts: qcom: Add power-controller device node for 8084 " Lina Iyer
2014-11-27  5:24 ` [PATCH v13 06/10] arm: dts: qcom: Update power-controller device node for 8064 " Lina Iyer
2014-11-27  5:24 ` [PATCH v13 07/10] qcom: cpuidle: Add cpuidle driver for QCOM cpus Lina Iyer
2014-11-27  5:24 ` [PATCH v13 08/10] arm: dts: qcom: Add idle states device nodes for 8074 Lina Iyer
2014-11-27  5:24 ` [PATCH v13 09/10] arm: dts: qcom: Add idle states device nodes for 8084 Lina Iyer
2014-11-27  5:24 ` [PATCH v13 10/10] arm: dts: qcom: Add idle state device nodes for 8064 Lina Iyer
2014-11-27  8:53 ` [PATCH v13 00/10] cpuidle driver for QCOM SoCs: 8064, 8074, 8084 Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141201175709.GA499@linaro.org \
    --to=lina.iyer@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=iivanov@mm-sol.com \
    --cc=khilman@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=msivasub@codeaurora.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).