From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] ARM: kbuild: Fix forced rebuild after 'make dtbs' Date: Thu, 4 Dec 2014 11:24:48 +0000 Message-ID: <20141204112448.GN11285@n2100.arm.linux.org.uk> References: <1414961549-31666-1-git-send-email-jason@lakedaemon.net> <5474F78F.2060906@suse.cz> <20141125235150.GH3836@n2100.arm.linux.org.uk> <20141126005710.GE22670@titan.lakedaemon.net> <20141126144153.GK3836@n2100.arm.linux.org.uk> <547C7364.8000009@suse.cz> <20141204112201.C824AC40992@trevor.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20141204112201.C824AC40992@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org To: Grant Likely Cc: Michal Marek , Linus Walleij , Jason Cooper , Rob Herring , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Thu, Dec 04, 2014 at 11:22:01AM +0000, Grant Likely wrote: > On Mon, 01 Dec 2014 14:55:48 +0100, Michal Marek wrote: > > Still, the dependency on the 'prepare' target is superfluous, if the > > only requirement is that $(KERNELRELEASE) be set properly. > > So, I've lost track of where things stand on this issue. What is the > current proposed fix? Make dtbs depend on 'scripts' and dtbs_install > depend on 'prepare scripts'? Or is there a better way to make sure > KERNELRELEASE is set for the dtbs_install target? Marek's first reply in the thread contains the solution: if you only need the KERNELRELEASE variable, then you do not need to depend on prepare. The main Makefile makes sure that silentoldconfig is ran and therefore KERNELRELEASE set for all targets except make *config. which seems to suggest that "prepare" is not needed for either target. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.