From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH V2 2/2] dmaengine: Add driver for IMG MDC Date: Sun, 7 Dec 2014 17:18:29 +0530 Message-ID: <20141207114829.GX3411@intel.com> References: <1416002384-3525-1-git-send-email-abrestic@chromium.org> <1416002384-3525-3-git-send-email-abrestic@chromium.org> <20141205173553.GS3411@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andrew Bresticker Cc: Dan Williams , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , James Hartley , James Hogan , Ezequiel Garcia , Damien Horsley , Arnd Bergmann , dmaengine@vger.kernel.org, "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Fri, Dec 05, 2014 at 10:30:53AM -0800, Andrew Bresticker wrote: > After adding a macro for setting the WIDTH_{R,W} fields it seems fine > to me. Is there something else you had in mind? I think whole of this might be a macro :) > > and this depends on dma_slave_config being set, which shouldn't be the case > > for memcpy okay looking back yes it depends on bus_width. But how is bus_width set, i thought the dma_slave_config will set that? -- ~Vinod