Re: [RFC/PATCH 5/7] arm: omap: hwmod: allow for registration of class-less hwmods

Tony Lindgren
2014-12-11T17:32:28Z

* Sebastian Reichel <sre@kernel.org> [141210 16:55]:
> On Wed, Dec 10, 2014 at 08:54:33AM -0600, Felipe Balbi wrote:
> > > @@ -2449,6 +2559,12 @@ static int __init _init(struct omap_hwmod *oh, void *data)
> > > else if (np && index)
> > > pr_warn("omap_hwmod: %s using broken dt data from %s\n",
> > > oh->name, np->name);
> > > +
> > > + if (np) {
> > > + r = omap_hwmod_init_sysc(np, oh, 0);
> >
> > this won't handle any binding which lists more than one hwmod on its
> > ti,hwmods property.
>
> I think Tony planned to remove this kind of multi hwmod references.

Yes we really should do that. But that involves repairs in the drivers,
dts files, and hwmod.

We really should aim for 1 to 1 to 1 mapping of the dts compatible
property to device hwmod to device sysc registers.

Once all the devices are mapped that way, we can deprecate
ti,hwmods in the dts files and set it up automatically based on
the compatible and the instance number of the device.

For an example of how to fix the interlaced device dts entries,
let's look at the EDMA. Instead of the current setup in
am33xx.dtsi:

edma: edma@49000000 {
compatible = "ti,edma3";
ti,hwmods = "tpcc", "tptc0", "tptc1", "tptc2";
reg = <0x49000000 0x10000>,
<0x44e10f90 0x40>;
interrupts = <12 13 14>;
#dma-cells = <1>;
};

It really should be set up in the following way (eventually
without ti,hwmods):

edma: edma@49000000 {
compatible = "ti,edma3";
reg = <0x49000000 0x10000>,
<0x44e10f90 0x40>;
interrupts = <12>;
#dma-cells = <1>;
};

tptc0 {
compatible = "ti,edma3-tptc";
reg = <0x49800000 0x100000>;
interrupts = <13>;
};

tptc1 {
compatible = "ti,edma3-tptc";
reg = <0x49900000 0x100000>;
interrupts = <14>;
};

tptc2 {
compatible = "ti,edma3-tptc";
reg = <0x49900000 0x100000>;
interrupts = <15>;
};

This is because each tptc entry has it's own sysc register and
can idle on it's own. With the above we can have 1 to 1 to 1 mapping
of compatible property to hwmod to sysc registers for each device.

> IMHO instead of DT referencing the hwmod stuff using ti,hwmods the
> hwmod database should reference the compatible values. This depends
> on omap3 being DT only of course.

Yes agreed.

Regards,

Tony