Re: [RFC/PATCH 2/7] arm: omap: devicetree: add new properties for OMAP devices

Lokesh Vutla
2014-12-10T11:07:19Z

Hi Felipe,

On Wednesday 10 December 2014 03:57 AM, Felipe Balbi wrote:
> In order to get rid of some more hwmod data, we
> introduce a few extra properties to OMAP DT
> data in order to be able to pass the needed
> information through DT.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
> Documentation/devicetree/bindings/arm/omap/omap.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt
> index 4f6a82c..c6b9515 100644
> --- a/Documentation/devicetree/bindings/arm/omap/omap.txt
> +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt
> @@ -23,6 +23,13 @@ Optional properties:
> during suspend.
> - ti,no-reset-on-init: When present, the module should not be reset at init
> - ti,no-idle-on-init: When present, the module should not be idled at init
> +- ti,rev_offs: IP block revision register offset (defaults to 0)
> +- ti,sysc_offs: OCP_SYSCONFIG register offset (defaults to 0)
> +- ti,syss_offs: OCP_SYSSTATUS register offset (defaults to 0)
> +- ti,srst_udelay: Delay needed after a softreset in usecs (defaults to 0)
> +- ti,idlemodes: Slave and Master supported idling modes
> +- ti,clockact: default value of clock activity bits (defaults to 0)
> +- ti,sysc_type: OCP_SYSCONFIG type. Valid types are 1, 2 or 3 (defaults to 1)
Once if all the hwmod data comes to dt it will be very dufficult to see all the data
together. Can we separate out hwmod class data like clocks data is separated out into different node
or something of the sort like below?

ti, hwmod_class {
ti,class_name = <>;
ti,rev_offs = <>;
ti,sysc_offs = <>;
ti,syss_offs = <>;
ti,srst_udelay = <>;
ti,idlemodes = <>;
ti,clockact = <>;
ti,sysc_type = <>;
};

example:
counter32k: counter@44e86000 {
compatible = "ti,am4372-counter32k","ti,omap-counter32k";
reg = <0x44e86000 0x40>;
ti,hwmods = "counter_32k";
ti,hwmod_class {
ti,class_name = "synctimer";
ti,idlemodes = <0x3>;
ti,sysc_flags = <0x20>;
ti,sysc_offs = <0x4>;
};
};

Thanks and regards,
Lokesh

>
> Example:
>
>